You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by ran-z <gi...@git.apache.org> on 2016/10/25 15:07:18 UTC
[GitHub] incubator-ariatosca pull request #13: ARIA-6 Add tox.ini and .travis files f...
GitHub user ran-z opened a pull request:
https://github.com/apache/incubator-ariatosca/pull/13
ARIA-6 Add tox.ini and .travis files for CI
The files actually existed but were out of date.
Both are now up to date. Tox will take care of installing both
code requirements and tests requirements before running the tests.
Additional changes:
- several setup.py changes (set version to 0.1.0; updated email)
- minor changes to tests' requirements (removed tox, froze mock)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-ariatosca ARIA-6-add-tox-and-travis-files
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-ariatosca/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit e267021bfe0a62f97f7550daa3906e20c9022b70
Author: Ran Ziv <ra...@gigaspaces.com>
Date: 2016-10-25T14:47:35Z
ARIA-6 Add tox.ini and .travis files for CI
The files actually existed but were out of date.
Both are now up to date. Tox will take care of installing both
code requirements and tests requirements before running the tests.
Additional changes:
- several setup.py changes (set version to 0.1.0; updated email)
- minor changes to tests' requirements (removed tox, froze mock)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #13: ARIA-6 Add tox.ini and .travis files f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-ariatosca/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #13: ARIA-6 Add tox.ini and .travis files f...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/13#discussion_r84926979
--- Diff: tox.ini ---
@@ -1,15 +1,39 @@
-# content of: tox.ini , put in same dir as setup.py
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
--- End diff --
Is it possible to enable something like RAT check in Python to verify and validate the Apache headers in all the files ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #13: ARIA-6 Add tox.ini and .travis files f...
Posted by ran-z <gi...@git.apache.org>.
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/13#discussion_r84929852
--- Diff: tox.ini ---
@@ -1,15 +1,39 @@
-# content of: tox.ini , put in same dir as setup.py
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
--- End diff --
I'm not familiar with such a tool unfortunately, but it's possible we should look more into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-ariatosca pull request #13: ARIA-6 Add tox.ini and .travis files f...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/13#discussion_r84932425
--- Diff: tox.ini ---
@@ -1,15 +1,39 @@
-# content of: tox.ini , put in same dir as setup.py
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
--- End diff --
Most of JVM projects - Java/Scala have a RAT plugin instrumented as part of the build to verify the license headers in each file, there must be something similar in Python that does it too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---