You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/01/30 12:24:38 UTC

[GitHub] LeiRui commented on a change in pull request #38: Fix sonar by Yanzhe An

LeiRui commented on a change in pull request #38: Fix sonar by Yanzhe An
URL: https://github.com/apache/incubator-iotdb/pull/38#discussion_r252233459
 
 

 ##########
 File path: iotdb-cli/src/main/java/org/apache/iotdb/cli/client/AbstractClient.java
 ##########
 @@ -301,7 +301,7 @@ private static String formatDatetime(long timestamp, ZoneId zoneId) {
     switch (timeFormat) {
       case "long":
       case "number":
-        return timestamp + "";
+        return Long.toString(timestamp) + "";
 
 Review comment:
   Long.toString is enough. 
    + "" is redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services