You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/06/30 05:46:29 UTC
[jira] Created: (HARMONY-714) [classlib][nio] Remove some "magic
number" related FIXMEs from java.nio.MappedByteBufferAdapter.
[classlib][nio] Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
------------------------------------------------------------------------------------------------
Key: HARMONY-714
URL: http://issues.apache.org/jira/browse/HARMONY-714
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Andrew Zhang
Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
I'll upload a patch to extract these contansts to final variables soon.
Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-714) [classlib][nio] Remove some "magic
number" related FIXMEs from java.nio.MappedByteBufferAdapter.
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-714?page=all ]
George Harley resolved HARMONY-714:
-----------------------------------
Resolution: Fixed
Hi Andrew,
Committed in revision 418481. Please could you verify that everything has been applied as expected.
Best regards,
George
> [classlib][nio] Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-714
> URL: http://issues.apache.org/jira/browse/HARMONY-714
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> I'll upload a patch to extract these contansts to final variables soon.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-714) [classlib][nio] Remove some "magic
number" related FIXMEs from java.nio.MappedByteBufferAdapter.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-714?page=comments#action_12418817 ]
Andrew Zhang commented on HARMONY-714:
--------------------------------------
Hello George,
The fix looks good. Thanks.
Best regards,
Andrew
> [classlib][nio] Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-714
> URL: http://issues.apache.org/jira/browse/HARMONY-714
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> I'll upload a patch to extract these contansts to final variables soon.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-714) [classlib][nio] Remove some "magic
number" related FIXMEs from java.nio.MappedByteBufferAdapter.
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-714?page=all ]
George Harley reassigned HARMONY-714:
-------------------------------------
Assign To: George Harley
> [classlib][nio] Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-714
> URL: http://issues.apache.org/jira/browse/HARMONY-714
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> I'll upload a patch to extract these contansts to final variables soon.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-714) [classlib][nio] Remove some "magic
number" related FIXMEs from java.nio.MappedByteBufferAdapter.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-714?page=all ]
Andrew Zhang updated HARMONY-714:
---------------------------------
Attachment: nio.diff
Hello,
Would you please try my patch?
Thanks!
Btw: I forgot to select "Minor" in priority. :(
Would anyone help me to change the priority to "minor"?
Best regards,
Andrew
> [classlib][nio] Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-714
> URL: http://issues.apache.org/jira/browse/HARMONY-714
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: nio.diff
>
> Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> I'll upload a patch to extract these contansts to final variables soon.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-714) [classlib][nio] Remove some "magic
number" related FIXMEs from java.nio.MappedByteBufferAdapter.
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-714?page=all ]
George Harley updated HARMONY-714:
----------------------------------
Priority: Minor (was: Major)
> [classlib][nio] Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-714
> URL: http://issues.apache.org/jira/browse/HARMONY-714
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: nio.diff
>
> Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> I'll upload a patch to extract these contansts to final variables soon.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-714) [classlib][nio] Remove some "magic
number" related FIXMEs from java.nio.MappedByteBufferAdapter.
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-714?page=all ]
George Harley closed HARMONY-714:
---------------------------------
Verified by Andrew.
> [classlib][nio] Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> ------------------------------------------------------------------------------------------------
>
> Key: HARMONY-714
> URL: http://issues.apache.org/jira/browse/HARMONY-714
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> Remove some "magic number" related FIXMEs from java.nio.MappedByteBufferAdapter.
> I'll upload a patch to extract these contansts to final variables soon.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira