You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2024/09/20 17:56:49 UTC
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21835
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
IMPALA-11934: Adjust the timeout interval for temporary file tests
This patch increases the timeout interval for temporary file test
cases. Initially, the timeout was set to 2 seconds, as it was for
hdfs files. However, after integrating ozone for temporary files,
this timeout seems too short for ozone uploads, causing some
related test cases in the ozone builds to become flaky. So, the
timeout is extended to 20 seconds in this patch.
Tests:
Ran disk-io-mgr-test and tmp-file-mgr-test, and no failures were
observed.
Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
---
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/tmp-file-mgr-test.cc
2 files changed, 30 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/21835/1
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 18:37:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 16:13:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21835/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21835/1//COMMIT_MSG@14
PS1, Line 14: timeout is extended to 20 seconds in this patch.
I would expect Ozone maybe 2x slower, not 10 times. And I think newer versions have addressed this. Why 10x?
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 18:07:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 18:30:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21835/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21835/1//COMMIT_MSG@14
PS1, Line 14: timeout is extended to 20 seconds in this patch.
> I would expect Ozone maybe 2x slower, not 10 times. And I think newer versi
I think the 10x increase is a safer buffer to prevent flaky test cases, and this shouldn't impact the overall runtime significantly, as the test will still exit early if uploads complete quickly. In most cases, the tests should finish within a second when things go smoothly
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 18:14:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
IMPALA-11934: Adjust the timeout interval for temporary file tests
This patch increases the timeout interval for temporary file test
cases. Initially, the timeout was set to 2 seconds, as it was for
hdfs files. However, after integrating ozone for temporary files,
this timeout seems too short for ozone uploads, causing some
related test cases in the ozone builds to become flaky. So, the
timeout is extended to 20 seconds in this patch.
Tests:
Ran disk-io-mgr-test and tmp-file-mgr-test, and no failures were
observed.
Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Reviewed-on: http://gerrit.cloudera.org:8080/21835
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/tmp-file-mgr-test.cc
2 files changed, 30 insertions(+), 50 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 18:15:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16991/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 18:30:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 3:
Thanks Michael and Andrew for the review.
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 19:11:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11934: Adjust the timeout interval for temporary file tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21835 )
Change subject: IMPALA-11934: Adjust the timeout interval for temporary file tests
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/387/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23ec44abd73426ed223aedb5d5634512861ac571
Gerrit-Change-Number: 21835
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 18:30:15 +0000
Gerrit-HasComments: No