You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Deepa Remesh (JIRA)" <de...@db.apache.org> on 2006/06/13 16:37:30 UTC
[jira] Created: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Cleanup code in network server's DRDAStatement class
----------------------------------------------------
Key: DERBY-1400
URL: http://issues.apache.org/jira/browse/DERBY-1400
Project: Derby
Type: Improvement
Components: Network Server, Newcomer
Versions: 10.2.0.0, 10.1.3.0
Reporter: Deepa Remesh
Priority: Trivial
The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
* pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
* Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Abhilash T.G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566612#action_12566612 ]
Abhilash T.G commented on DERBY-1400:
-------------------------------------
i dont know much about the standards..can you pls elaborate on that.
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566628#action_12566628 ]
Kristian Waagan commented on DERBY-1400:
----------------------------------------
Not quite sure what you are asking about, but I'll try to help.
Regarding the patch, remove all changes that are not directly related to your cleanup of the DRDAStatement code, like adding/removing/replacing spaces or tabs at places where you haven't done any other change.
You should also run the tests to make sure you haven't broken anything. You can find instructions and information at the wiki, and I think all the relevant pointers are in the following two mail threads:
http://www.nabble.com/Derby-Testing-td15205194.html
http://www.nabble.com/Newbie-to-Derby-Testing-td15312500.html
I (or someone else ) will have another look at the updated patch after the unnecessary whitespace changes have been removed.
I know running the tests can be a bit of a pain the first times, but it is something you have to go through if you plan to contribute patches.
BTW: I noticed that the patch does not apply to trunk any more due to a conflicting change in the same file. It also conflicts if I revert to the revision the patch was generated from and then do svn up. So I think you might have to generate a new patch.
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564352#action_12564352 ]
Kristian Waagan commented on DERBY-1400:
----------------------------------------
Thanks for providing the patch, Abhilash.
I had a quick look at it, and it seems to me it is a lot bigger than it has to be because of unrelated whitespace changes.
There is a preference in the Derby community to leave unrelated whitespace changes out of patches fixing other issues. I do notice that the class you are working on (DRDAStatement) contains a mix of tabs and spaces, and also a number of lines with trailing whitespace.
The current policy for new Derby source code is to use four spaces for indentation.
1) Can you please make another patch, where you don't incorporate unrelated whitespace changes?
2) Have you run any regression tests for the changes?
If you have questions, feel free to ask!
thanks,
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-1400:
--------------------------------------
Derby Info: [Patch Available]
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden reassigned DERBY-1400:
-------------------------------------
Assignee: (was: Abhilash T.G)
Unassigning due to inactivity. Please reassign yourself if you would like to work on this issue.
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Abhilash T.G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhilash T.G updated DERBY-1400:
--------------------------------
Attachment: DERBY-1400.diff
made tha changes
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Abhilash T.G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhilash T.G reassigned DERBY-1400:
-----------------------------------
Assignee: Abhilash T.G
I would like to work on this
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dyre Tjeldvoll updated DERBY-1400:
----------------------------------
Derby Info: (was: [Patch Available])
Let's see if I can manage to uncheck the box this time...
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Abhilash T.G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566608#action_12566608 ]
Abhilash T.G commented on DERBY-1400:
-------------------------------------
ca you pls help me with it.
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1400) Cleanup code in network server's
DRDAStatement class
Posted by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dyre Tjeldvoll updated DERBY-1400:
----------------------------------
Removing patch flag since the patch can no longer be applied.
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to modify the comments at places it is currently called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.