You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@systemml.apache.org by "Matthias Boehm (JIRA)" <ji...@apache.org> on 2017/07/06 00:29:00 UTC

[jira] [Commented] (SYSTEMML-1737) BufferedReader should be closed in ParameterizedBuiltinCPFileInstruction#createCellResultFile()

    [ https://issues.apache.org/jira/browse/SYSTEMML-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075686#comment-16075686 ] 

Matthias Boehm commented on SYSTEMML-1737:
------------------------------------------

Thanks for catching this [~tedyu]. Would you mind creating a PR for properly closing this (and the other two instances which might not be closed in case of failures)?

> BufferedReader should be closed in ParameterizedBuiltinCPFileInstruction#createCellResultFile()
> -----------------------------------------------------------------------------------------------
>
>                 Key: SYSTEMML-1737
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1737
>             Project: SystemML
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>       BufferedReader fkeyMap = StagingFileUtils.openKeyMap(metaOut);
> {code}
> BufferedReader should be closed upon exit from method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)