You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/08 02:44:25 UTC

[GitHub] [hudi] YuweiXiao opened a new pull request, #6629: [HUDI-4807] Use base table instant for metadata table initialization

YuweiXiao opened a new pull request, #6629:
URL: https://github.com/apache/hudi/pull/6629

   ### Change Logs
   
   Use base table instant for metadata table initialization
   
   ### Impact
   
   No public API change.
   
   **Risk level: none | low | medium | high**
   
   None.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope commented on pull request #6629: [HUDI-4807] Use base table instant for metadata table initialization

Posted by GitBox <gi...@apache.org>.
codope commented on PR #6629:
URL: https://github.com/apache/hudi/pull/6629#issuecomment-1240716869

   @nsivabalan Can you take a look as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YuweiXiao commented on pull request #6629: [HUDI-4807] Use base table instant for metadata table initialization

Posted by GitBox <gi...@apache.org>.
YuweiXiao commented on PR #6629:
URL: https://github.com/apache/hudi/pull/6629#issuecomment-1241421204

   > @YuweiXiao Can you please add more details in the PR description? It would be great if you add a test as well.
   
   Have added some details. Feel like it is not easy to add a test for it, as the failure only occurs when we modify `HoodieAppendHandle` (i.e., in the consistent hashing PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6629: [HUDI-4807] Use base table instant for metadata table initialization

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6629:
URL: https://github.com/apache/hudi/pull/6629#issuecomment-1240470563

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c88a869d5d8e748edac75698c7c504176a06e47d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11238",
       "triggerID" : "c88a869d5d8e748edac75698c7c504176a06e47d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c88a869d5d8e748edac75698c7c504176a06e47d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11238) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6629: [HUDI-4807] Use base table instant for metadata table initialization

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6629:
URL: https://github.com/apache/hudi/pull/6629#issuecomment-1240181342

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c88a869d5d8e748edac75698c7c504176a06e47d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11238",
       "triggerID" : "c88a869d5d8e748edac75698c7c504176a06e47d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c88a869d5d8e748edac75698c7c504176a06e47d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11238) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope commented on pull request #6629: [HUDI-4807] Use base table instant for metadata table initialization

Posted by GitBox <gi...@apache.org>.
codope commented on PR #6629:
URL: https://github.com/apache/hudi/pull/6629#issuecomment-1242152015

    > Have added some details. Feel like it is not easy to add a test for it, as the failure only occurs when we modify `HoodieAppendHandle` (i.e., in the consistent hashing PR).
   
   I see. Can you explain for my understanding, what change in consistent hashing PR triggers the bug?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6629: [HUDI-4807] Use base table instant for metadata table initialization

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6629:
URL: https://github.com/apache/hudi/pull/6629#issuecomment-1240178412

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c88a869d5d8e748edac75698c7c504176a06e47d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c88a869d5d8e748edac75698c7c504176a06e47d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c88a869d5d8e748edac75698c7c504176a06e47d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope merged pull request #6629: [HUDI-4807] Use base table instant for metadata table initialization

Posted by GitBox <gi...@apache.org>.
codope merged PR #6629:
URL: https://github.com/apache/hudi/pull/6629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org