You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/03 07:06:50 UTC
[GitHub] [bookkeeper] casuallc opened a new pull request #2785: [ISSUE 2784] get local host from config file
casuallc opened a new pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785
Descriptions of the changes in this PR:
#2784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc commented on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-958588493
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc commented on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-965952026
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc removed a comment on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc removed a comment on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-958588493
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc removed a comment on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc removed a comment on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-965952026
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc removed a comment on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc removed a comment on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-958588493
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc removed a comment on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc removed a comment on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-958588493
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc commented on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-958588493
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc commented on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-928694543
> Please add unit tests and add new config into the default conf file with description to make the feature discoverable.
>
> I think this might be useful for hosts with multiple network interfaces
@dlg99 I do not think there need a new config, we just use the existed config `advertisedAddress`.
If we use `InetAddress.getLocalHost()` instead of use config `advertisedAddress`, there is problem.
I add more log, take a look please. #2784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc commented on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-928694543
> Please add unit tests and add new config into the default conf file with description to make the feature discoverable.
>
> I think this might be useful for hosts with multiple network interfaces
@dlg99 I do not think there need a new config, we just use the existed config `advertisedAddress`.
If we use `InetAddress.getLocalHost()` instead of use config `advertisedAddress`, there is problem.
I add more log, take a look please. #2784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] casuallc commented on pull request #2785: [ISSUE 2784] get local host from config file
Posted by GitBox <gi...@apache.org>.
casuallc commented on pull request #2785:
URL: https://github.com/apache/bookkeeper/pull/2785#issuecomment-958588493
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org