You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/05/06 11:07:59 UTC
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1107:
TINKERPOP-2206 Fixed g:List serialization
jorgebay commented on a change in pull request #1107: TINKERPOP-2206 Fixed g:List serialization
URL: https://github.com/apache/tinkerpop/pull/1107#discussion_r281139199
##########
File path: gremlin-javascript/glv/TraversalSource.template
##########
@@ -149,7 +149,24 @@ class P {
or(arg) {
return new P('or', this, arg);
}
-<% pmethods.each{ method -> %>
+
+ static within(...args) {
+ if (args.length == 1 && Array.isArray(args[0])) {
Review comment:
NIT: strict equality in js is `===`, we should use strict equality whenever possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services