You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/18 11:17:44 UTC

[GitHub] [shardingsphere] yu199195 opened a new pull request #5676: YamlRuleConfiguration is generated dynamically based on the user's co…

yu199195 opened a new pull request #5676:
URL: https://github.com/apache/shardingsphere/pull/5676


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu merged pull request #5676: YamlRuleConfiguration is generated dynamically based on the user's co…

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5676:
URL: https://github.com/apache/shardingsphere/pull/5676


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io commented on pull request #5676: YamlRuleConfiguration is generated dynamically based on the user's co…

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5676:
URL: https://github.com/apache/shardingsphere/pull/5676#issuecomment-630143489


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5676?src=pr&el=h1) Report
   > Merging [#5676](https://codecov.io/gh/apache/shardingsphere/pull/5676?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7cb43abe2d10ed83a6138a8f564d6b42d2e7eaf2&el=desc) will **decrease** coverage by `0.13%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5676/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5676?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5676      +/-   ##
   ============================================
   - Coverage     55.98%   55.84%   -0.14%     
   - Complexity      432      436       +4     
   ============================================
     Files          1139     1143       +4     
     Lines         20213    20231      +18     
     Branches       3660     3661       +1     
   ============================================
   - Hits          11317    11299      -18     
   - Misses         8220     8259      +39     
   + Partials        676      673       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5676?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ver/spring/boot/rule/DefaultRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zcHJpbmcvYm9vdC9ydWxlL0RlZmF1bHRSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...spring/boot/rule/SpringBootRulesConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zcHJpbmcvYm9vdC9ydWxlL1NwcmluZ0Jvb3RSdWxlc0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/driver/spring/boot/SpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvc3ByaW5nL2Jvb3QvU3ByaW5nQm9vdENvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ing/boot/OrchestrationSpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLW9yY2hlc3RyYXRpb24tc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvb3JjaGVzdHJhdGlvbi9zcHJpbmcvYm9vdC9PcmNoZXN0cmF0aW9uU3ByaW5nQm9vdENvbmZpZ3VyYXRpb24uamF2YQ==) | `91.66% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ing/boot/condition/EncryptSpringBootCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zcHJpbmcvYm9vdC9jb25kaXRpb24vRW5jcnlwdFNwcmluZ0Jvb3RDb25kaXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...boot/condition/MasterSlaveSpringBootCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zcHJpbmcvYm9vdC9jb25kaXRpb24vTWFzdGVyU2xhdmVTcHJpbmdCb290Q29uZGl0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ring/boot/condition/ShadowSpringBootCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zcHJpbmcvYm9vdC9jb25kaXRpb24vU2hhZG93U3ByaW5nQm9vdENvbmRpdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ng/boot/condition/ShardingSpringBootCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zcHJpbmcvYm9vdC9jb25kaXRpb24vU2hhcmRpbmdTcHJpbmdCb290Q29uZGl0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../shardingsphere/kernal/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...river/jdbc/core/context/SchemaContextsBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvY29udGV4dC9TY2hlbWFDb250ZXh0c0J1aWxkZXIuamF2YQ==) | | | |
   | ... and [8 more](https://codecov.io/gh/apache/shardingsphere/pull/5676/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5676?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5676?src=pr&el=footer). Last update [7cb43ab...9b38b79](https://codecov.io/gh/apache/shardingsphere/pull/5676?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org