You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/10 16:22:02 UTC
[GitHub] [rocketmq] areyouok opened a new pull request #3479: [Issue #3476] Fix last separator of properties string is missing when using batch send
areyouok opened a new pull request #3479:
URL: https://github.com/apache/rocketmq/pull/3479
## What is the purpose of the change
This problem introduced since 4.9.1, may cause tag incorrect.
in https://github.com/apache/rocketmq/pull/2961 MessageDecoder.messageProperties2String remove last separator. MessageDecoder.string2messageProperties can parse the string with or without last separator, but CommitLog.MessageExtEncoder.encode(MessageExtBatch, PutMessageContext) force append some properties without separator.
## Brief changelog
This problem need fix in broker side. since different client may send messages in different format.
## Verifying this change
I will check compatibility of this commit tomorrow.
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] areyouok commented on pull request #3479: [Issue #3476] Fix last separator of properties string is missing when using batch send
Posted by GitBox <gi...@apache.org>.
areyouok commented on pull request #3479:
URL: https://github.com/apache/rocketmq/pull/3479#issuecomment-966200864
I think there is no problem in this commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #3479: [Issue #3476] Fix last separator of properties string is missing when using batch send
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #3479:
URL: https://github.com/apache/rocketmq/pull/3479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3479: [Issue #3476] Fix last separator of properties string is missing when using batch send
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3479:
URL: https://github.com/apache/rocketmq/pull/3479#issuecomment-965693799
[](https://coveralls.io/builds/44173020)
Coverage decreased (-0.02%) to 54.54% when pulling **c282367a8b948b3275f6d27616520a6878f440cf on areyouok:fix_batch_tag** into **b35f3e4459e8cf32116bb15133aaa27d5ff63cfb on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org