You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Balaji Seshadri <as...@gmail.com> on 2014/12/05 20:00:10 UTC
Re: Review Request 27693: Patch for KAFKA-1476
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27693/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 7 p.m.)
Review request for kafka.
Bugs: KAFKA-1476
https://issues.apache.org/jira/browse/KAFKA-1476
Repository: kafka
Description (updated)
-------
KAFKA-1476 Implemented review comments from Neha and Ashish
Diffs (updated)
-----
core/src/main/scala/kafka/tools/ConsumerCommand.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd
Diff: https://reviews.apache.org/r/27693/diff/
Testing
-------
Thanks,
Balaji Seshadri
Re: Review Request 27693: Patch for KAFKA-1476
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27693/#review64483
-----------------------------------------------------------
The patches may not have been tested before submitting for a review. I suggest you also attach example output of each of the options along with the reviewboard, so it's complete. Please refer to my comments on the JIRA for requirements on the tool usage
core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment107198>
group->groups
core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment107197>
group->groups
core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment107199>
how does this work? How does the user specify the group name? I'm guessing we should include a --group option that is required for describe groups?
core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment107201>
Shouldn't we also provide an option --topic to let the user specify a particular topic for the describe/offset stuff?
- Neha Narkhede
On Dec. 5, 2014, 7:03 p.m., Balaji Seshadri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27693/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 7:03 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1476
> https://issues.apache.org/jira/browse/KAFKA-1476
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1476 Implemented review comments from Neha and Ashish
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/ConsumerCommand.scala PRE-CREATION
> core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd
>
> Diff: https://reviews.apache.org/r/27693/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Balaji Seshadri
>
>
Re: Review Request 27693: Patch for KAFKA-1476
Posted by Balaji Seshadri <as...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27693/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 7:03 p.m.)
Review request for kafka.
Bugs: KAFKA-1476
https://issues.apache.org/jira/browse/KAFKA-1476
Repository: kafka
Description
-------
KAFKA-1476 Implemented review comments from Neha and Ashish
Diffs (updated)
-----
core/src/main/scala/kafka/tools/ConsumerCommand.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd
Diff: https://reviews.apache.org/r/27693/diff/
Testing
-------
Thanks,
Balaji Seshadri