You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (JIRA)" <ji...@apache.org> on 2013/12/19 21:47:07 UTC

[jira] [Created] (SHINDIG-1963) Change content-type logic in TokenAuthorizationResponseHandler so application/x-www-form-urlencoded is the default

Ryan Baxter created SHINDIG-1963:
------------------------------------

             Summary: Change content-type logic in TokenAuthorizationResponseHandler so application/x-www-form-urlencoded is the default 
                 Key: SHINDIG-1963
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1963
             Project: Shindig
          Issue Type: Improvement
    Affects Versions: 2.5.0-update1, 2.5.0
            Reporter: Ryan Baxter
            Assignee: Ryan Baxter


There is logic in TokenAuthorizationResponseHandler that looks at the content type of the auth response and tried to get the access token and other properties from the response based on the response type.  The logic was specific to certain providers, ie Google uses one content type, Facebook uses another.  I ran into a problem today where the GitHub provider used a different content type but essentially was the same as Facebook.  To simplify things I think we should default to handling the response as application/x-www-form-urlencoded unless they specify a different content type that we know how to handle (right now that is application/json).



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)