You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/15 10:00:11 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
utchoang opened a new pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808
Fixes #807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-726175200
@rhtyd @davidjumani is this ready to go? 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-713271817
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/808 (JID-3605)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-734373369
@davidjumani can you clarify where you use "quiescevm" in VMware and which feature you want to test? there are normal VM Snapshots and i only know volume snapshot like VVOLs. Do you speak about VVOLs (virtual volumes)? Can you link or clarify the test?
Maybe we dont need an VMware test because there is no functionality they use the volume snapshot and qiescing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-736351646
@davidjumani how can we proceed? i see there is a parameter but which time it is used?
if there is no test scenario then why are we testing it? normally functionality is not changed to old UI.
take a look here. its included in the old UI.
@rhtyd @utchoang @davidjumani is the master frozen? i think this is ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-758093176
@rhtyd @davidjumani @GabrielBrascher can we merge? @utchoang could do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-726593438
> @utchoang There also needs to be a check for `quiescevm` on the volume
> https://github.com/apache/cloudstack/blob/master/ui/scripts/instances.js#L1255
@davidjumani so what i see is that there is no squeezing in managed storage. we dont need at the moment an quiesed button.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-736446776
I too don't see any blocker here since it works as expected but would like the snapshot API call tested on a volume with quiescevm enabled (mocked also works fine)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-730152096
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/808 (JID-3678)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-727248376
@davidjumani @utchoang maybe I am wrong but there is NO qiescevm on a managed storage volume. I don’t know if there is something in VMware but I think the mechanism is another one. Please refer #3724 in cloudstack.
https://github.com/apache/cloudstack/pull/3724#issue-346702676
If this so we can remove the quiescing and it’s at the Moment for volume snapshots not important.
@rhtyd can you clarify?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-709070091
@rhtyd @svenvogel Please review it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] GabrielBrascher commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-736392837
Well, from what I understand, what it matters here is not the hypervisor (VMware). But the volume itself with quiescevm enabled. One can test it by mocking such situation.
Also, the API returns such information on the list volumes call which enabled to implement the UI on same approach as the old UI. I don't see any problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-759229922
I'm okay with having this merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-713267859
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-730148987
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-726593438
> @utchoang There also needs to be a check for `quiescevm` on the volume
> https://github.com/apache/cloudstack/blob/master/ui/scripts/instances.js#L1255
wo what i see is that there is no squeezing in managed storage. we dont need at the moment an quiesed button.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-726597725
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-734373369
@davidjumani can you clarify where you use "quiescevm" in VMware and which feature you want to test? there are normal VM Snapshots and i only know volume snapshot like VVOLs. Do you speak about VVOLs? Can you link or clarify the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-726597087
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-713268221
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-736360598
@davidjumani @rhtyd Do you test OK and ready to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-709079318
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-758093176
@davidjumani @GabrielBrascher can we merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-709096667
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/808 (JID-3591)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-709077265
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-730148588
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-726598925
@davidjumani Please review again. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-736446776
I too don't see any blocker here but would like the snapshot API call tested on a volume with quiescevm enabled (mocked also works fine)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-758423027
@rhtyd @davidjumani cc @svenvogel Is it possible to merge this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-709069369
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-735560849
@svenvogel Not too sure about it but I do see it as a parameter in volume snapshot as well as while creating VMware snapshots
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-712821081
@utchoang There also needs to be a check for `quiescevm` on the volume
https://github.com/apache/cloudstack/blob/master/ui/scripts/instances.js#L1255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-709069110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
svenvogel edited a comment on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-734373369
@davidjumani can you clarify where you use "quiescevm" in VMware and which feature you want to test? there are normal VM Snapshots and i only know volume snapshot like VVOLs. Do you speak about VVOLs (virtual volumes)? Can you link or clarify the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #808:
URL: https://github.com/apache/cloudstack-primate/pull/808#issuecomment-726601907
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/808 (JID-3664)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org