You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2026/06/16 16:27:16 UTC
[PR] refactor(core): delegate presign_stat/presign_read to their _with variants [opendal]
Xuanwo opened a new pull request, #7775:
URL: https://github.com/apache/opendal/pull/7775
# Which issue does this PR close?
No associated issue; this is a small internal refactor.
# Rationale for this change
`presign_stat` and `presign_read` inlined their own `OpPresign` construction, while `presign_write` and `presign_delete` already delegate to their `*_with` variants. Aligning all four removes the duplicated presign plumbing and keeps a single code path per operation.
# What changes are included in this PR?
`presign_stat` and `presign_read` now delegate to `presign_stat_with` / `presign_read_with`.
The change is behavior-preserving:
- `presign_stat_with` defaults to `OpStat::from(StatOptions::default())`, which maps field-by-field to `OpStat::new()`.
- `presign_read_with` defaults to `ReadOptions::default()`, whose conversion yields `BytesRange::default()` and an `OpRead` equal to `OpRead::new()` (the `OpReader` is discarded for presign), matching the previous inline path.
# Are there any user-facing changes?
No.
# AI Usage Statement
This PR was prepared with Claude Code (Opus 4.8). All changes were reviewed and verified by the author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core): delegate presign_stat/presign_read to their _with variants [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #7775:
URL: https://github.com/apache/opendal/pull/7775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org