You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/01/18 13:24:39 UTC
Re: Review Request 65212: Updated `mesos-tidy` docker build setup for
benchmarks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65212/
-----------------------------------------------------------
(Updated Jan. 18, 2018, 2:24 p.m.)
Review request for mesos and Michael Park.
Summary (updated)
-----------------
Updated `mesos-tidy` docker build setup for benchmarks.
Repository: mesos
Description
-------
This patch updates the `mesos-tidy` docker build setup to generate
`benchmarks.pb.h` needed by the libprocess benchmark files added as
part of `eb901173b8aa43b9fd1ab0f727ff5187982c4449`.
We also reorder the targets to be build in the script so that all
proto targets are located close to each other and after manually
triggered 3rdparty dependencies (like e.g., protobuf). This should
reduce redudant build invocations.
Diffs (updated)
-----
support/mesos-tidy/entrypoint.sh dd83d66f48968bce652bc78ccf2d807949f1725b
Diff: https://reviews.apache.org/r/65212/diff/2/
Changes: https://reviews.apache.org/r/65212/diff/1-2/
Testing (updated)
-------
Tested with a custom docker image and `support/mesos-tidy.sh` pointing to it.
Thanks,
Benjamin Bannier
Re: Review Request 65212: Updated `mesos-tidy` docker build setup for
benchmarks.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65212/#review195723
-----------------------------------------------------------
PASS: Mesos patch 65212 was successfully built and tested.
Reviews applied: `['65212']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65212
- Mesos Reviewbot Windows
On Jan. 18, 2018, 1:24 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65212/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 1:24 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the `mesos-tidy` docker build setup to generate
> `benchmarks.pb.h` needed by the libprocess benchmark files added as
> part of `eb901173b8aa43b9fd1ab0f727ff5187982c4449`.
>
> We also reorder the targets to be build in the script so that all
> proto targets are located close to each other and after manually
> triggered 3rdparty dependencies (like e.g., protobuf). This should
> reduce redudant build invocations.
>
>
> Diffs
> -----
>
> support/mesos-tidy/entrypoint.sh dd83d66f48968bce652bc78ccf2d807949f1725b
>
>
> Diff: https://reviews.apache.org/r/65212/diff/2/
>
>
> Testing
> -------
>
> Tested with a custom docker image and `support/mesos-tidy.sh` pointing to it.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65212: Updated `mesos-tidy` docker build setup for
benchmarks.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65212/#review195742
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Jan. 18, 2018, 5:24 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65212/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 5:24 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the `mesos-tidy` docker build setup to generate
> `benchmarks.pb.h` needed by the libprocess benchmark files added as
> part of `eb901173b8aa43b9fd1ab0f727ff5187982c4449`.
>
> We also reorder the targets to be build in the script so that all
> proto targets are located close to each other and after manually
> triggered 3rdparty dependencies (like e.g., protobuf). This should
> reduce redudant build invocations.
>
>
> Diffs
> -----
>
> support/mesos-tidy/entrypoint.sh dd83d66f48968bce652bc78ccf2d807949f1725b
>
>
> Diff: https://reviews.apache.org/r/65212/diff/2/
>
>
> Testing
> -------
>
> Tested with a custom docker image and `support/mesos-tidy.sh` pointing to it.
>
>
> Thanks,
>
> Benjamin Bannier
>
>