You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2021/02/18 23:31:25 UTC

[thrift] branch master updated: THRIFT-5354 disable IDE0083 warning Client: netstd Patch: Jens Geyer

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new c15e75d  THRIFT-5354 disable IDE0083 warning Client: netstd Patch: Jens Geyer
c15e75d is described below

commit c15e75d4acaa9cd804dd3f6c5e732508f9118f64
Author: Jens Geyer <je...@apache.org>
AuthorDate: Fri Feb 19 00:06:09 2021 +0100

    THRIFT-5354 disable IDE0083 warning
    Client: netstd
    Patch: Jens Geyer
    
    The recommended pattern matching expression \"that is not SomeType\" requires C#9/net5.0 but we still want to support earlier versions (.NET Core 3.1 is LTS until 2022-DEC-03)
---
 compiler/cpp/src/thrift/generate/t_netstd_generator.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/compiler/cpp/src/thrift/generate/t_netstd_generator.cc b/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
index 5048c0e..5fb3f55 100644
--- a/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
@@ -335,6 +335,7 @@ void t_netstd_generator::start_netstd_namespace(ostream& out)
 {
     out << "#pragma warning disable IDE0079  // remove unnecessary pragmas" << endl
         << "#pragma warning disable IDE1006  // parts of the code use IDL spelling" << endl
+        << "#pragma warning disable IDE0083  // pattern matching \"that is not SomeType\" requires net5.0 but we still support earlier versions" << endl
         << endl;
 
     if (!namespace_name_.empty())