You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/23 21:50:56 UTC
[GitHub] [maven-scm] cquoss opened a new pull request #119: Make limit parameter work for svnexe and gitexe changelog goal
cquoss opened a new pull request #119:
URL: https://github.com/apache/maven-scm/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] eolivelli commented on pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #119:
URL: https://github.com/apache/maven-scm/pull/119#issuecomment-886149569
Can you please explain more your patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] cquoss edited a comment on pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
cquoss edited a comment on pull request #119:
URL: https://github.com/apache/maven-scm/pull/119#issuecomment-886156115
Happily. The old PR was better documented but got erased after resetting hard to upstream master and force pushing.
At our company we use a customized version of maven-release that talks in some added phases with our jira.
To be more precise we extract in one phase the current jira issue related with this maven project from the latest scm commit comment.
To not have the scm provider always drill down through the complete log history i also customized maven-scm in our nexus repository to only return the latest log entry by making the limit parameter functional for the changelog goal for the two providers we are interested in (gitexe and svnexe).
My patch here may not be perfect but with all the abstraction and the already deprecated methods i made two attempts in the past (the first inventing new methods and instantly deprecating them, the second removing all deprecation from the code and directly go through request -> parameters to command line creation).
Both have been rejected so now this is my third attempt doing this by overriding the createCommand method for these two providers mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #119:
URL: https://github.com/apache/maven-scm/pull/119#issuecomment-893708840
Note: The order how those options are processed differ between Subversion and Git. This is bad for consistency, but not your fault I do not expect you to fix that. The change looks fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] cquoss edited a comment on pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
cquoss edited a comment on pull request #119:
URL: https://github.com/apache/maven-scm/pull/119#issuecomment-886156115
Happily. The old PR was better documented but got erased after resetting hard to upstream master and force pushing.
At our company we use a customized version of maven-release that talks in some added phases with our jira.
To be more precise we extract in one phase the current jira issue related with this maven project from the latest scm commit comment.
To not have the scm provider always drill down through the complete log history i also customized maven-scm in our nexus repository to only return the latest log entry by making the limit parameter functional for the changelog goal for the two providers we are interested in (gitexe and svnexe).
My patch here may not be perfect but with all the abstraction and the already deprecated methods i made two attempts in the past (the first inventing new methods and instantly deprecating them, the second removing all deprecation from the code and directly go through request -> parameters to command line creation).
Both have been rejected so now this is my third attempt doing this by overriding the executeCommand method for these two providers mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] cquoss commented on pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
cquoss commented on pull request #119:
URL: https://github.com/apache/maven-scm/pull/119#issuecomment-886156115
Happily. The old PR was better documented but got erased after resetting hard to upstream master and force pushing.
At our company we use a customized version of maven-release that talks in some added phases with our jira.
To be more precise we extract in one phase the current jira issue related with this maven project from the latest scm commit comment.
To not have the scm provider always drill down through the complete log history i also customized maven-scm in our nexus repository to only return the latest log entry by making the limit parameter functional for the changelog goal for the two providers we are interested in (gitexe and svnexe).
My patch here may not be perfect but with also the abstraction and the already deprecated methods i already made two attempts (the first inventing new methods and instantly deprecating them, the second removing all deprecation from the code and directly go through request -> parameters to command line creation).
Both have been rejected so now this is my third attempt doing this by overriding the createCommand method for these two providers mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #119:
URL: https://github.com/apache/maven-scm/pull/119#discussion_r683708334
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
##########
@@ -148,9 +169,21 @@ protected ChangeLogScmResult executeChangeLogCommand( ScmProviderRepository repo
// ----------------------------------------------------------------------
/**
- * this constructs creates the commandline for the git-whatchanged command.
+ * <p>
Review comment:
This `<p>` isn't necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] asfgit closed pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #119:
URL: https://github.com/apache/maven-scm/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] cquoss commented on pull request #119: SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal
Posted by GitBox <gi...@apache.org>.
cquoss commented on pull request #119:
URL: https://github.com/apache/maven-scm/pull/119#issuecomment-886160733
Another thing: Travis CI builds for jdk 7 and 8 have errors. To me it looks like jdk 7 and 8 are not available. Is some on it to fix the config on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org