You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by el...@apache.org on 2014/02/01 04:23:14 UTC
[15/26] git commit: Missed a UTF8 and an unnecessary String creation.
Missed a UTF8 and an unnecessary String creation.
Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/9a9b419e
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/9a9b419e
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/9a9b419e
Branch: refs/heads/2292-findbugs
Commit: 9a9b419eacab87003cf7f3e6862845925a6f4ec0
Parents: 9320788
Author: Josh Elser <el...@apache.org>
Authored: Fri Jan 31 14:17:21 2014 -0500
Committer: Josh Elser <el...@apache.org>
Committed: Fri Jan 31 22:18:53 2014 -0500
----------------------------------------------------------------------
.../apache/accumulo/core/util/shell/commands/HiddenCommand.java | 2 +-
.../apache/accumulo/core/util/shell/commands/SetIterCommand.java | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/accumulo/blob/9a9b419e/core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java b/core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java
index 37b9ec0..41594ca 100644
--- a/core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java
+++ b/core/src/main/java/org/apache/accumulo/core/util/shell/commands/HiddenCommand.java
@@ -43,7 +43,7 @@ public class HiddenCommand extends Command {
shellState.getReader().printString(
new String(Base64.decodeBase64(("ICAgICAgIC4tLS4KICAgICAgLyAvXCBcCiAgICAgKCAvLS1cICkKICAgICAuPl8gIF88LgogICAgLyB8ICd8ICcgXAog"
+ "ICAvICB8Xy58Xy4gIFwKICAvIC98ICAgICAgfFwgXAogfCB8IHwgfFwvfCB8IHwgfAogfF98IHwgfCAgfCB8IHxffAogICAgIC8gIF9fICBcCiAgICAvICAv"
- + "ICBcICBcCiAgIC8gIC8gICAgXCAgXF8KIHwvICAvICAgICAgXCB8IHwKIHxfXy8gICAgICAgIFx8X3wK").getBytes()), Constants.UTF8));
+ + "ICBcICBcCiAgIC8gIC8gICAgXCAgXF8KIHwvICAvICAgICAgXCB8IHwKIHxfXy8gICAgICAgIFx8X3wK").getBytes(Constants.UTF8)), Constants.UTF8));
shellState.getReader().printNewline();
} else {
throw new ShellCommandException(ErrorCode.UNRECOGNIZED_COMMAND, getName());
http://git-wip-us.apache.org/repos/asf/accumulo/blob/9a9b419e/core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetIterCommand.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetIterCommand.java b/core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetIterCommand.java
index 7c71e59..275b1b0 100644
--- a/core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetIterCommand.java
+++ b/core/src/main/java/org/apache/accumulo/core/util/shell/commands/SetIterCommand.java
@@ -242,8 +242,6 @@ public class SetIterCommand extends Command {
if (input == null) {
reader.printNewline();
throw new IOException("Input stream closed");
- } else {
- input = new String(input);
}
if (input.length() == 0)