You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/06/11 20:36:42 UTC
[jira] [Created] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
stack created HBASE-6199:
----------------------------
Summary: Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
Key: HBASE-6199
URL: https://issues.apache.org/jira/browse/HBASE-6199
Project: HBase
Issue Type: Improvement
Reporter: stack
PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293301#comment-13293301 ]
Hadoop QA commented on HBASE-6199:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12531715/6199v4.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2140//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2140//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2140//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2140//console
This message is automatically generated.
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 6199v4.txt, pending_open.txt, pending_open2.txt, pending_open3.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6199:
-------------------------
Attachment: 6199v4.txt
Cleaner version (the v3 didn't apply to fresh trunk)
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 6199v4.txt, pending_open.txt, pending_open2.txt, pending_open3.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6199:
-------------------------
Assignee: stack
Status: Patch Available (was: Open)
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: pending_open.txt, pending_open2.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6199:
-------------------------
Attachment: pending_open.txt
Lets see how this patch does.
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Attachments: pending_open.txt, pending_open2.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6199:
-------------------------
Status: Open (was: Patch Available)
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 6199v4.txt, pending_open.txt, pending_open2.txt, pending_open3.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6199:
-------------------------
Attachment: pending_open3.txt
Fix comments.
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: pending_open.txt, pending_open2.txt, pending_open3.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6199:
-------------------------
Attachment: pending_open2.txt
First patch had mistake in it.
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: pending_open.txt, pending_open2.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6199:
-------------------------
Status: Patch Available (was: Open)
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 6199v4.txt, pending_open.txt, pending_open2.txt, pending_open3.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6199) Change PENDING_OPEN scope from
pre-rpc open to OPENING to just post-rpc open to OPENING
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293240#comment-13293240 ]
Hadoop QA commented on HBASE-6199:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12531715/6199v4.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2135//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2135//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2135//console
This message is automatically generated.
> Change PENDING_OPEN scope from pre-rpc open to OPENING to just post-rpc open to OPENING
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-6199
> URL: https://issues.apache.org/jira/browse/HBASE-6199
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 6199v4.txt, pending_open.txt, pending_open2.txt, pending_open3.txt
>
>
> PENDING_OPEN currently is a murky state. Its a master in-memory state with no corresponding znode state that sits between OFFLINE and OPENING states.
> The OFFLINE state is set by the master when it goes to open a region. OPENING is set by the regionserver after its assumed control of a region and is moving it through the OPENING process. PENDING_OPEN currently spans the open rpc invocation. This state is in place pre-open-rpc-invocation, during open-rpc-invocation, and post-rpc-invocation until we get the OPENING callback. That PENDING_OPEN covers this many different conditions effectively makes it unactionable.
> This issue proposes PENDING_OPEN only be in place post-rpc-invocation. Now its meaning is clear as the space between rpc-open-invocation and our receiving the callback which sets RegionState to OPENING. PENDING_OPEN becomes actionable too in that if a regionserver dies post rpc-open-invocation, we know that we can reassign the region.
> See https://issues.apache.org/jira/browse/HBASE-6060?focusedCommentId=13292646&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13292646 for more discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira