You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/02/04 16:22:04 UTC

Review Request 30616: Added hdfs::du()

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30616/
-----------------------------------------------------------

Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2072
    https://issues.apache.org/jira/browse/MESOS-2072


Repository: mesos


Description
-------

Adds hdfs::du() which calls "hadoop fs -du -h" and returns a string that contains the file size for the URI passed as argument. This is needed to determine the size of a file on HDFS before downloading it to the fetcher cache (to ensure there is enough space).


Diffs
-----

  src/hdfs/hdfs.hpp 968545d9af896f3e72e156484cc58135405cef6b 

Diff: https://reviews.apache.org/r/30616/diff/


Testing
-------

None yet. This will be tested in the course of tests for fetcher cache functionality added to MESOS-2072. See later dependent patches.


Thanks,

Bernd Mathiske


Re: Review Request 30616: Added hdfs::du()

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30616/#review70975
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30616]

All tests passed.

- Mesos ReviewBot


On Feb. 4, 2015, 3:22 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30616/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 3:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2072
>     https://issues.apache.org/jira/browse/MESOS-2072
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds hdfs::du() which calls "hadoop fs -du -h" and returns a string that contains the file size for the URI passed as argument. This is needed to determine the size of a file on HDFS before downloading it to the fetcher cache (to ensure there is enough space).
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.hpp 968545d9af896f3e72e156484cc58135405cef6b 
> 
> Diff: https://reviews.apache.org/r/30616/diff/
> 
> 
> Testing
> -------
> 
> None yet. This will be tested in the course of tests for fetcher cache functionality added to MESOS-2072. See later dependent patches.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>