You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/11/25 17:59:54 UTC
[kudu-CR] [java] Fix remaining checkstyle warnings
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14795
Change subject: [java] Fix remaining checkstyle warnings
......................................................................
[java] Fix remaining checkstyle warnings
This patch fixes all of the checkstlyle warnings reported by:
./gradlew :checkstyle
I also included some trivial style changes and suppression annotations.
A follow on patch will enforce confoming to checkstyle rules in the
pre-commit build.
Change-Id: I90d317b24c45b2cba069be0c7289751203194f98
---
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/BackupIO.scala
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup-common/src/test/scala/org/apache/kudu/backup/TestBackupGraph.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCleaner.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestUtils.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupUtils.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/RowAction.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/DistributedDataGeneratorTest.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/HdrHistogramAccumulator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduReadOptions.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkListenerUtil.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/StreamingTest.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryInfo.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
75 files changed, 713 insertions(+), 590 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/14795/1
--
To view, visit http://gerrit.cloudera.org:8080/14795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90d317b24c45b2cba069be0c7289751203194f98
Gerrit-Change-Number: 14795
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Fix remaining checkstyle warnings
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14795 )
Change subject: [java] Fix remaining checkstyle warnings
......................................................................
[java] Fix remaining checkstyle warnings
This patch fixes all of the checkstlyle warnings reported by:
./gradlew :checkstyle
I also included some trivial style changes and suppression annotations.
A follow on patch will enforce confoming to checkstyle rules in the
pre-commit build.
Change-Id: I90d317b24c45b2cba069be0c7289751203194f98
Reviewed-on: http://gerrit.cloudera.org:8080/14795
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/BackupIO.scala
M java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup-common/src/test/scala/org/apache/kudu/backup/TestBackupGraph.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCleaner.scala
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestUtils.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupUtils.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/RowAction.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/BigLinkedListCommon.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/CsvParser.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/RowCounter.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableInputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/DistributedDataGeneratorTest.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/HdrHistogramAccumulator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduReadOptions.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduWriteOptions.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkListenerUtil.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/StreamingTest.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ProtobufUtils.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryInfo.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/AssertHelpers.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestCapturingToFileLogAppender.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java
75 files changed, 713 insertions(+), 590 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90d317b24c45b2cba069be0c7289751203194f98
Gerrit-Change-Number: 14795
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Fix remaining checkstyle warnings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14795 )
Change subject: [java] Fix remaining checkstyle warnings
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14795/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java:
http://gerrit.cloudera.org:8080/#/c/14795/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/RandomUtils.java@46
PS1, Line 46: LOG.info("System property {} is defined. Overriding random seed: {}",
Good catch.
--
To view, visit http://gerrit.cloudera.org:8080/14795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90d317b24c45b2cba069be0c7289751203194f98
Gerrit-Change-Number: 14795
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Nov 2019 04:30:59 +0000
Gerrit-HasComments: Yes