You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/27 23:52:31 UTC

[GitHub] [apisix-ingress-controller] elvis-cai opened a new pull request #726: feat: add externalname support for upstream

elvis-cai opened a new pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   https://github.com/apache/apisix-ingress-controller/issues/645
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
     - Adding kubernetes service type `ExternalName` support
     - For kind: ApisixUpstream, add two more options `passHost` and `upstreamHost`
   
   Let me know if there's anything missing here, thanks. 
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-1065843139


   @elvis-cai Could you merge the newest master branch? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] elvis-cai commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
elvis-cai commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-965822888


   > @elvis-cai Please add some test cases to cover these changes.
   
   sure, doc & test added. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] purekeeper commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
purekeeper commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-1065833234


   @tokers @tao12345666333     Why this feature not merge to master, Can you go ahead to process this feature ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r737942838



##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -126,6 +126,14 @@ type ApisixUpstreamConfig struct {
 	// service versions.
 	// +optional
 	Subsets []ApisixUpstreamSubset `json:"subsets,omitempty" yaml:"subsets,omitempty"`
+
+	// The host option sent to the upstream, value can be pass, node and rewrite.

Review comment:
       I'm afraid the `node` type is meaningless in the scenario. Since we either use the ClusterIP or the pod IPs, and even for ExternalName type service, we have just one "node", so actually only `pass` and `rewrite` are required.
   
   Also, `pass` and `rewrite` are not so semantic, I prefer to use some more descriptive terms here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r739905226



##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -126,6 +126,14 @@ type ApisixUpstreamConfig struct {
 	// service versions.
 	// +optional
 	Subsets []ApisixUpstreamSubset `json:"subsets,omitempty" yaml:"subsets,omitempty"`
+
+	// The host option sent to the upstream, value can be pass, node and rewrite.

Review comment:
       > That's a good point, there's another scenario the link is https://gist.github.com/elvis-cai/c3774867af113f901e69bde7e41de154, if using `curl -H "Host: local.httpbin.org" ${APISIX_GATEWAY} `, since by default pass_host is pass, apisix will use `host header: local.httpbin.org` to hit the ip address of `apple.internal.com`, or we will set `pass_host: node` by default when accessing ExternalName service in k8s?
   > 
   > Any suggestions for the naming `pass` and `rewrite` would be apprecated, thanks.
   
   The literals should keep the "what you see is what you get" principle, so what about `"httpHostRewritePolicy"`, the candidates can be `"useOriginalClientHost"` and `"rewriteTo"` (in such a case, we have to use another field to specify the target host, saying `"target"`), and `useEndpointHostnameOrAddress`.
   
   ```yaml
   httpHostRewritePolicy:
     kind: useOriginalClientHost
   
   httpHostRewritePolicy:
     kind: rewriteTo
     target: blah.blah.foo.com
   
   httpHostRewritePolicy:
     kind: useEndpointHostnameOrAddress
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] elvis-cai commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
elvis-cai commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r744344894



##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -126,6 +126,14 @@ type ApisixUpstreamConfig struct {
 	// service versions.
 	// +optional
 	Subsets []ApisixUpstreamSubset `json:"subsets,omitempty" yaml:"subsets,omitempty"`
+
+	// The host option sent to the upstream, value can be pass, node and rewrite.

Review comment:
       applogise for the late reply, that sounds great, updated the PR, here's another example of httpHostRewritePolicy https://gist.github.com/elvis-cai/1e7179f114bb4f8390cf6a63e8dc5fe4




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-965879979


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#726](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12563f5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b127ff4) will **decrease** coverage by `0.13%`.
   > The diff coverage is `67.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #726      +/-   ##
   ==========================================
   - Coverage   32.50%   32.36%   -0.14%     
   ==========================================
     Files          66       65       -1     
     Lines        6800     6835      +35     
   ==========================================
   + Hits         2210     2212       +2     
   - Misses       4340     4362      +22     
   - Partials      250      261      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `47.32% <55.55%> (+1.24%)` | :arrow_up: |
   | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `32.16% <58.82%> (-0.56%)` | :arrow_down: |
   | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `83.33% <88.23%> (+0.38%)` | :arrow_up: |
   | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.02% <0.00%> (-3.31%)` | :arrow_down: |
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b127ff4...12563f5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-965879979


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#726](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab32fd3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc196ef16f95217213321335c6fc3929578e304a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc196ef) will **decrease** coverage by `0.44%`.
   > The diff coverage is `20.79%`.
   
   > :exclamation: Current head ab32fd3 differs from pull request most recent head 8670494. Consider uploading reports for the commit 8670494 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #726      +/-   ##
   ==========================================
   - Coverage   32.30%   31.86%   -0.45%     
   ==========================================
     Files          65       65              
     Lines        6500     6675     +175     
   ==========================================
   + Hits         2100     2127      +27     
   - Misses       4149     4289     +140     
   - Partials      251      259       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/compare.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29tcGFyZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/namespace.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvbmFtZXNwYWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.01% <5.00%> (-0.05%)` | :arrow_down: |
   | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `62.50% <13.79%> (-23.95%)` | :arrow_down: |
   | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `75.82% <50.00%> (-1.45%)` | :arrow_down: |
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `48.18% <55.55%> (+1.18%)` | :arrow_up: |
   | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `32.16% <58.82%> (-0.56%)` | :arrow_down: |
   | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.47% <88.23%> (-0.03%)` | :arrow_down: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc196ef...8670494](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] elvis-cai commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
elvis-cai commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-968385288


   > Please fix the CI errors.
   
   my bad, last commit forget to update test code, updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-965879979


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#726](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f44e6d2) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc196ef16f95217213321335c6fc3929578e304a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc196ef) will **increase** coverage by `67.69%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##           master      #726       +/-   ##
   ============================================
   + Coverage   32.30%   100.00%   +67.69%     
   ============================================
     Files          65         1       -64     
     Lines        6500         1     -6499     
   ============================================
   - Hits         2100         1     -2099     
   + Misses       4149         0     -4149     
   + Partials      251         0      -251     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | | |
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | | |
   | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | | |
   | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | | |
   | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | | |
   | [pkg/types/event.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL2V2ZW50Lmdv) | | |
   | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | | |
   | [pkg/ingress/pod.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvcG9kLmdv) | | |
   | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | | |
   | [pkg/kube/translation/apisix\_ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3NzbC5nbw==) | | |
   | ... and [54 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc196ef...f44e6d2](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] elvis-cai commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
elvis-cai commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r739887506



##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -126,6 +126,14 @@ type ApisixUpstreamConfig struct {
 	// service versions.
 	// +optional
 	Subsets []ApisixUpstreamSubset `json:"subsets,omitempty" yaml:"subsets,omitempty"`
+
+	// The host option sent to the upstream, value can be pass, node and rewrite.

Review comment:
       That's a good point, there's another scenario the link is https://gist.github.com/elvis-cai/c3774867af113f901e69bde7e41de154, if using `curl -H "Host: local.httpbin.org" ${APISIX_GATEWAY} `,  since by default pass_host is pass,  apisix will use `host header: local.httpbin.org` to hit the ip address of `apple.internal.com`,  or we will set `pass_host: node` by default when accessing ExternalName service in k8s?
   
   Any suggestions for the naming `pass` and `rewrite` would be apprecated, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] elvis-cai commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
elvis-cai commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r747423428



##########
File path: docs/en/latest/concepts/apisix_upstream.md
##########
@@ -193,3 +193,33 @@ In the meanwhile, the ApisixUpstream `foo` sets `http` scheme for port `7000` an
 (all ports are the service port). But both ports shares the load balancer configuration.
 
 `PortLevelSettings` is not mandatory if the service only exposes one port but is useful when multiple ports are defined.
+
+### Http Host Rewrite Policy

Review comment:
       thanks for pointing out, rerun markdownlint and gofmt locally to fix the format issue. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-962779188


   @elvis-cai Please add some test cases to cover these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r756021342



##########
File path: docs/en/latest/concepts/apisix_upstream.md
##########
@@ -193,3 +193,33 @@ In the meanwhile, the ApisixUpstream `foo` sets `http` scheme for port `7000` an
 (all ports are the service port). But both ports shares the load balancer configuration.
 
 `PortLevelSettings` is not mandatory if the service only exposes one port but is useful when multiple ports are defined.
+
+### Http Host Rewrite Policy
+This is mainly used for external service outside the Kubernetes cluster, you can configure different host rewrite policies when the request is sent to the upstream.
+Here's an example of kubernetes service used in the test case.
+```
+kind: Service
+apiVersion: v1
+metadata:
+  name: foo-service
+spec:
+  type: ExternalName
+  externalName: foo.com
+  ports:
+  - name: http
+    port: 80
+    protocol: TCP
+    targetPort: 80
+```
+The following configuration configures `useRewriteTo` rewrite policy to change the host option to `foo.org`.
+```
+apiVersion: apisix.apache.org/v1
+kind: ApisixUpstream
+metadata:
+  name: foo-service
+spec:
+  httpHostRewritePolicy:

Review comment:
       @elvis-cai  and this one




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-965879979


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#726](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12563f5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b127ff4) will **decrease** coverage by `0.12%`.
   > The diff coverage is `67.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #726      +/-   ##
   ==========================================
   - Coverage   32.50%   32.37%   -0.13%     
   ==========================================
     Files          66       66              
     Lines        6800     6836      +36     
   ==========================================
   + Hits         2210     2213       +3     
   - Misses       4340     4362      +22     
   - Partials      250      261      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `47.32% <55.55%> (+1.24%)` | :arrow_up: |
   | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `32.16% <58.82%> (-0.56%)` | :arrow_down: |
   | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `83.33% <88.23%> (+0.38%)` | :arrow_up: |
   | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.02% <0.00%> (-3.31%)` | :arrow_down: |
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b127ff4...12563f5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-1065833997


   There are too many conflicts to resolve.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r747925062



##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -23,6 +23,15 @@ import (
 	"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2alpha1"
 )
 
+const (
+	// UseOriginalClientHost means host option set to "pass" for the upstream
+	UseOriginalClientHost = "useOriginalClientHost"

Review comment:
       As per the Kubernetes convention, the value should be in upper camel case. Like values of `ImagePullPolicy`: `Always`, `Never`, `IfNotPresent`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r748949570



##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -126,6 +126,14 @@ type ApisixUpstreamConfig struct {
 	// service versions.
 	// +optional
 	Subsets []ApisixUpstreamSubset `json:"subsets,omitempty" yaml:"subsets,omitempty"`
+
+	// The host option sent to the upstream, value can be pass, node and rewrite.

Review comment:
       👍




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r747143769



##########
File path: docs/en/latest/concepts/apisix_upstream.md
##########
@@ -193,3 +193,33 @@ In the meanwhile, the ApisixUpstream `foo` sets `http` scheme for port `7000` an
 (all ports are the service port). But both ports shares the load balancer configuration.
 
 `PortLevelSettings` is not mandatory if the service only exposes one port but is useful when multiple ports are defined.
+
+### Http Host Rewrite Policy

Review comment:
       Add an empty line after this title.

##########
File path: docs/en/latest/concepts/apisix_upstream.md
##########
@@ -193,3 +193,33 @@ In the meanwhile, the ApisixUpstream `foo` sets `http` scheme for port `7000` an
 (all ports are the service port). But both ports shares the load balancer configuration.
 
 `PortLevelSettings` is not mandatory if the service only exposes one port but is useful when multiple ports are defined.
+
+### Http Host Rewrite Policy
+This is mainly used for external service outside the Kubernetes cluster, you can configure different host rewrite policies when the request is sent to the upstream.
+Here's an example of kubernetes service used in the test case.
+```
+kind: Service
+apiVersion: v1
+metadata:
+  name: foo-service
+spec:
+  type: ExternalName
+  externalName: foo.com
+  ports:
+  - name: http
+    port: 80
+    protocol: TCP
+    targetPort: 80
+```
+The following configuration configures `useRewriteTo` rewrite policy to change the host option to `foo.org`.
+```
+apiVersion: apisix.apache.org/v1
+kind: ApisixUpstream
+metadata:
+  name: foo-service
+spec:
+  httpHostRewritePolicy:

Review comment:
       The specification is bad. You should split them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] elvis-cai commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
elvis-cai commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-978488784


   > Sorry for delay. Can you resolve the conflict? Then we run the test and merge this PR. Thanks!
   
   all good, conflict resolved and feel free to rerun the test, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] elvis-cai commented on a change in pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
elvis-cai commented on a change in pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r744344894



##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -126,6 +126,14 @@ type ApisixUpstreamConfig struct {
 	// service versions.
 	// +optional
 	Subsets []ApisixUpstreamSubset `json:"subsets,omitempty" yaml:"subsets,omitempty"`
+
+	// The host option sent to the upstream, value can be pass, node and rewrite.

Review comment:
       applogise for the late reply, updated, here's another example of httpHostRewritePolicy https://gist.github.com/elvis-cai/1e7179f114bb4f8390cf6a63e8dc5fe4




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #726: feat: add externalname support for upstream

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #726:
URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-977837122


   Sorry for delay. Can you resolve the conflict? Then we run the test and merge this PR. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org