You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/10/08 00:04:53 UTC

[PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

kou opened a new pull request, #47746:
URL: https://github.com/apache/arrow/pull/47746

   ### Rationale for this change
   
   This is for preventing to break Apache Arrow Java JNI use case on Linux.
   
   ### What changes are included in this PR?
   
   * Add a CI job that uses build options for JNI use case
   * Install more packages in manylinux image that is also used by JNI build 
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3394599251

   > @raulcd Can we merge this for 22.0.0?
   
   Yes, I'll cherry-pick it on the maintenance branch once we merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2437996702


##########
ci/scripts/cpp_test.sh:
##########
@@ -114,6 +120,41 @@ else
     "$@"
 fi
 
+# This is for testing find_package(Arrow).
+#
+# Note that this is not a perfect solution. We should improve this
+# later.

Review Comment:
   Oh, sorry. I missed these failures: https://github.com/apache/arrow/issues/47840



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2416703457


##########
.github/workflows/cpp_extra.yml:
##########
@@ -76,6 +76,7 @@ concurrency:
 
 permissions:
   contents: read
+  packages: write

Review Comment:
   Can you add a comment about this?



##########
cpp/CMakePresets.json:
##########
@@ -582,6 +582,37 @@
       "displayName": "Benchmarking build with everything enabled",
       "cacheVariables": {}
     },
+    {
+      "name": "ninja-release-jni-linux",
+      "inherits": [
+        "base-release"
+      ],
+      "displayName": "Build for JNI on Linux",
+      "cacheVariables": {
+        "ARROW_ACERO": "ON",
+        "ARROW_BUILD_SHARED": "OFF",
+        "ARROW_BUILD_STATIC": "ON",

Review Comment:
   I'm surprised, wouldn't we want shared libs with JNI?



##########
ci/scripts/cpp_build.sh:
##########
@@ -174,6 +174,11 @@ elif [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     ${ARROW_CMAKE_ARGS} \
     ${source_dir}
+elif [ -n "${CMAKE_PRESET}" ]; then
+  cmake \
+    --preset="${CMAKE_PRESET}" \
+    ${ARROW_CMAKE_ARGS} \
+    ${source_dir}

Review Comment:
   Why not pass `--preset` to the existing `cmake` call below? 



##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -89,7 +89,9 @@ RUN --mount=type=secret,id=github_repository_owner \
         --x-install-root=${VCPKG_ROOT}/installed \
         --x-manifest-root=/arrow/ci/vcpkg \
         --x-feature=azure \
+        --x-feature=dev \
         --x-feature=flight \
+        --x-feature=gandiva \

Review Comment:
   Same question. This will build LLVM, right??



##########
ci/scripts/cpp_test.sh:
##########
@@ -114,6 +120,34 @@ else
     "$@"
 fi
 
+if [ "${ARROW_USE_MESON:-OFF}" = "OFF" ] && \

Review Comment:
   Who are these additions related to JNI?



##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -89,7 +89,9 @@ RUN --mount=type=secret,id=github_repository_owner \
         --x-install-root=${VCPKG_ROOT}/installed \
         --x-manifest-root=/arrow/ci/vcpkg \
         --x-feature=azure \
+        --x-feature=dev \

Review Comment:
   Do we really need to enable this for Python wheels?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2418366740


##########
cpp/CMakePresets.json:
##########
@@ -582,6 +582,37 @@
       "displayName": "Benchmarking build with everything enabled",
       "cacheVariables": {}
     },
+    {
+      "name": "ninja-release-jni-linux",
+      "inherits": [
+        "base-release"
+      ],
+      "displayName": "Build for JNI on Linux",
+      "cacheVariables": {
+        "ARROW_ACERO": "ON",
+        "ARROW_BUILD_SHARED": "OFF",
+        "ARROW_BUILD_STATIC": "ON",

Review Comment:
   Hmm. Shared libraries will not work. Or we need to set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH`/`PATH` in JNI to use shared libraries.
   
   Python wheels use shared libraries because one "pyarrow" package includes all modules such as compute and dataset. So Python wheels can find `libarrow.so`/`libarrow_compute.so`/`libarrow_dataset.so`/... from the same directory. But JNI uses separated packages such as arrow-dataset and arrow-flight: https://repo1.maven.org/maven2/org/apache/arrow/
   
   If we use shared libraries in JNI, arrow-dataset needs to find `libarrow.so` from other package. I'm not sure whether JNI can do it but I think that we need to set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH`/`PATH` for it.
   
   If we split pyarrow to pyarrow-core, pyarrow-dataset, ... or something, Python wheels may face the same problem. #22300 may be related.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2418356538


##########
ci/scripts/cpp_test.sh:
##########
@@ -114,6 +120,34 @@ else
     "$@"
 fi
 
+if [ "${ARROW_USE_MESON:-OFF}" = "OFF" ] && \

Review Comment:
   This is for testing `find_package(Arrow)`: https://github.com/apache/arrow/pull/47746#discussion_r2412214047
   
   I'll add a comment for this part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2418329110


##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -89,7 +89,9 @@ RUN --mount=type=secret,id=github_repository_owner \
         --x-install-root=${VCPKG_ROOT}/installed \
         --x-manifest-root=/arrow/ci/vcpkg \
         --x-feature=azure \
+        --x-feature=dev \

Review Comment:
   Yes, to reuse this image for build configuration for JNI.
   
   I think that reusing this image reduces maintenance cost but you don't want to increase this image size, right?
   
   I'll create a new image for build configuration for JNI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2416365399


##########
.github/workflows/cpp_extra.yml:
##########
@@ -76,6 +76,7 @@ concurrency:
 
 permissions:
   contents: read
+  packages: write

Review Comment:
   This is for using GitHub Packages as vcpkg cache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3396244897

   > This is also a blocker of 22.0.0.
   
   Thanks for pointing that out!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2432680408


##########
ci/scripts/cpp_test.sh:
##########
@@ -114,6 +120,41 @@ else
     "$@"
 fi
 
+# This is for testing find_package(Arrow).
+#
+# Note that this is not a perfect solution. We should improve this
+# later.

Review Comment:
   It seems that this new check is breaking some C++ builds (CUDA, Thread Sanitizer). @kou 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2418796298


##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -89,7 +89,9 @@ RUN --mount=type=secret,id=github_repository_owner \
         --x-install-root=${VCPKG_ROOT}/installed \
         --x-manifest-root=/arrow/ci/vcpkg \
         --x-feature=azure \
+        --x-feature=dev \

Review Comment:
   My main concern is that it makes vcpkg build times even larger when the cache isn't fresh or there is no cache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3396223542

   `docker compose push` failed: #47795
   
   This is also a blocker of 22.0.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3388957676

   This is ready.
   
   This is a blocker of new Apache Arrow Java release. So this is needed for 22.0.0 C++ release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2412211418


##########
ci/scripts/cpp_build.sh:
##########
@@ -308,10 +313,14 @@ fi
 popd
 
 if [ -x "$(command -v ldconfig)" ]; then
-  if [ -x "$(command -v sudo)" ]; then
-    SUDO=sudo
-  else
+  if [ "$(id --user)" -eq 0 ]; then

Review Comment:
   We don't need to use `sudo` with the root user.
   
   manylinux image doesn't provide `/usr/bin/sudo` but `/opt/rh/gcc-toolset-12/root/usr/bin/sudo` exists.



##########
ci/scripts/cpp_test.sh:
##########
@@ -47,6 +47,12 @@ ctest_options=()
 if ! type azurite >/dev/null 2>&1; then
   exclude_tests+=("arrow-azurefs-test")
 fi
+if ! type storage-testbench >/dev/null 2>&1; then
+  exclude_tests+=("arrow-gcsfs-test")
+fi
+if ! type minio >/dev/null 2>&1; then
+  exclude_tests+=("arrow-s3fs-test")
+fi

Review Comment:
   They don't exist in manylinux image.



##########
ci/scripts/cpp_test.sh:
##########
@@ -114,6 +120,21 @@ else
     "$@"
 fi
 
+if [ "${ARROW_USE_MESON:-OFF}" = "OFF" ] && [ "${ARROW_EMSCRIPTEN:-OFF}" = "OFF" ]; then
+  CMAKE_PREFIX_PATH="${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}}"
+  if [ -n "${VCPKG_ROOT}" ] && [ -n "${VCPKG_TARGET_TRIPLET}" ]; then
+    CMAKE_PREFIX_PATH+=";${VCPKG_ROOT}/installed/${VCPKG_TARGET_TRIPLET}"
+  fi
+  cmake \
+    -S ${source_dir}/examples/minimal_build \
+    -B ${build_dir}/examples/minimal_build \
+    -DCMAKE_PREFIX_PATH="${CMAKE_PREFIX_PATH}"
+  cmake --build ${build_dir}/examples/minimal_build
+  pushd ${source_dir}/examples/minimal_build
+  ${build_dir}/examples/minimal_build/arrow-example
+  popd
+fi

Review Comment:
   This is a test for our CMake packages. If `find_package(Arrow)` doesn't work, this will detect it.
   
   JNI build uses `find_package(Arrow)`.



##########
ci/scripts/cpp_build.sh:
##########
@@ -174,6 +174,11 @@ elif [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     ${ARROW_CMAKE_ARGS} \
     ${source_dir}
+elif [ -n "${CMAKE_PRESET}" ]; then
+  cmake \
+    --preset="${CMAKE_PRESET}" \
+    ${ARROW_CMAKE_ARGS} \
+    ${source_dir}

Review Comment:
   We want to provide preset for JNI build to share build options in apache/arrow and apache/arrow-java.



##########
ci/vcpkg/vcpkg.json:
##########
@@ -19,6 +19,7 @@
     "re2",
     "snappy",
     "utf8proc",
+    "xsimd",

Review Comment:
   We can add this again because we have #47221 and vcpkg provides xsimd 13.2.0 since #47627.



##########
ci/docker/python-wheel-manylinux.dockerfile:
##########
@@ -89,7 +89,9 @@ RUN --mount=type=secret,id=github_repository_owner \
         --x-install-root=${VCPKG_ROOT}/installed \
         --x-manifest-root=/arrow/ci/vcpkg \
         --x-feature=azure \
+        --x-feature=dev \

Review Comment:
   This is for `ARROW_BUILD_TESTS=ON`.



##########
cpp/src/arrow/testing/process.cc:
##########
@@ -176,7 +176,7 @@ class Process::Impl {
       for (const auto& kv : process::environment::current()) {
         env[kv.key()] = process::environment::value(kv.value());
       }
-      env["PATH"] = process::environment::value(current_exe.parent_path());
+      env["PATH"] = process::environment::value(current_exe.parent_path().string());

Review Comment:
   Recent Boost or old g++ (12.2.1) don't accept `std::filesystem::path`:
   
   ```text
   /arrow/cpp/src/arrow/testing/process.cc: In member function ‘arrow::Status arrow::util::Process::Impl::SetExecutable(const std::string&)’:
   /arrow/cpp/src/arrow/testing/process.cc:179:74: error: call of overloaded ‘value(std::filesystem::__cxx11::path)’ is ambiguous
     179 |       env["PATH"] = process::environment::value(current_exe.parent_path());
         |                                                                          ^
   In file included from /arrow/cpp/src/arrow/testing/process.cc:44:
   /opt/vcpkg/installed/amd64-linux-static-release/include/boost/process/v2/environment.hpp:727:14: note: candidate: ‘boost::process::v2::environment::value::value(boost::process::v2::environment::value_view)’
     727 |     explicit value(value_view kv) : value_(kv.c_str()) {}
         |              ^~~~~
   /opt/vcpkg/installed/amd64-linux-static-release/include/boost/process/v2/environment.hpp:723:5: note: candidate: ‘boost::process::v2::environment::value::value(string_type&&)’
     723 |     value( string_type&& source ) : value_(std::move(source)) {}
         |     ^~~~~
   /opt/vcpkg/installed/amd64-linux-static-release/include/boost/process/v2/environment.hpp:722:5: note: candidate: ‘boost::process::v2::environment::value::value(const string_type&)’
     722 |     value( const string_type& source ) : value_(source) {}
         |     ^~~~~
   ```
   
   We need to convert `std::filesystem::path` to `std::string` explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3394615625

   Thanks. Let's merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3379094572

   :warning: GitHub issue #47632 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2418315676


##########
.github/workflows/cpp_extra.yml:
##########
@@ -76,6 +76,7 @@ concurrency:
 
 permissions:
   contents: read
+  packages: write

Review Comment:
   Done and moved to `steps.jni-linux.permissions` from the top-level `permissions` to reduce scope.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47746:
URL: https://github.com/apache/arrow/pull/47746#discussion_r2418354585


##########
ci/scripts/cpp_build.sh:
##########
@@ -174,6 +174,11 @@ elif [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
     -DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
     ${ARROW_CMAKE_ARGS} \
     ${source_dir}
+elif [ -n "${CMAKE_PRESET}" ]; then
+  cmake \
+    --preset="${CMAKE_PRESET}" \
+    ${ARROW_CMAKE_ARGS} \
+    ${source_dir}

Review Comment:
   If we use it, all variables by `--preset` are overridden because it specify most variables explicitly. Explicit variables are used instead of variables set by `--preset`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #47746:
URL: https://github.com/apache/arrow/pull/47746


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3395418200

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0c8ce5f8dfa33f9268fe01a269f2c9d86bddbec5.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/52562841134) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-47632: [CI][C++] Add a CI job for JNI on Linux [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47746:
URL: https://github.com/apache/arrow/pull/47746#issuecomment-3393255722

   @raulcd Can we merge this for 22.0.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org