You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/15 19:17:35 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #22263: Add default connection for redshift and update doc

potiuk commented on a change in pull request #22263:
URL: https://github.com/apache/airflow/pull/22263#discussion_r827331258



##########
File path: airflow/utils/db.py
##########
@@ -508,6 +508,22 @@ def create_default_connections(session: Session = NEW_SESSION):
         ),
         session,
     )
+    merge_conn(
+        Connection(
+            conn_id='redshift_default',
+            conn_type='redshift',
+            extra="""{
+    "iam": true,
+    "cluster_identifier": "my-redshift-cluster-identifier",
+    "port": 5439,
+    "profile": "default",
+    "db_user": "awsuser",
+    "database": "dev",
+    "region": "us-east-1"

Review comment:
       Good point. I think thoguh leavin it empty is a better Idea ? What happens if someone uses the `<>` one?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org