You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 21:51:07 UTC
[GitHub] [airflow] pavel-lexyr opened a new pull request, #23135: Adding support for multiple hostnames in Task Instances
pavel-lexyr opened a new pull request, #23135:
URL: https://github.com/apache/airflow/pull/23135
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR aims to fix a long-standing logging bug present in Airflow. In particular, any clusters of more than one worker do not handle their logs appropriately - always fetching files from the host used in the last run.
This change replaces the `hostname` field of the `TaskInstance` object with a list `hostnames`, storing a separate hostname for each run of the job.
This iteration is not final. If you have any comments, do not hesitate to post them.
In particular, the areas I am looking for feedback on are:
- [ ] Is the AIP process necessary for this kind of change? If so, how would one ensure it goes smoothly?
- [ ] What kinds of tests should be added?
- [ ] A database migration is needed for this change. What is the appropriate way to implement one?
closes: #16472
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23135: Adding support for multiple hostnames in Task Instances
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23135:
URL: https://github.com/apache/airflow/pull/23135#issuecomment-1104486551
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pavel-lexyr commented on pull request #23135: Adding support for multiple hostnames in Task Instances
Posted by GitBox <gi...@apache.org>.
pavel-lexyr commented on PR #23135:
URL: https://github.com/apache/airflow/pull/23135#issuecomment-1106770752
That's a reasonable idea. I'll close and restart it as a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #23135: Adding support for multiple hostnames in Task Instances
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #23135:
URL: https://github.com/apache/airflow/pull/23135#issuecomment-1106086275
Instead of trying to implicitly looking up the correct hostname based on try_number, it may be better to introduce a new table altogether to keep the `(ti, try_number) -> hostname` lookup. Or a dict (via JSON column).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pavel-lexyr closed pull request #23135: Adding support for multiple hostnames in Task Instances
Posted by GitBox <gi...@apache.org>.
pavel-lexyr closed pull request #23135: Adding support for multiple hostnames in Task Instances
URL: https://github.com/apache/airflow/pull/23135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org