You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/17 07:31:14 UTC
[GitHub] [flink] lirui-apache commented on a change in pull request #11093: [FLINK-16055][hive] Avoid catalog functions when listing Hive built-i…
lirui-apache commented on a change in pull request #11093: [FLINK-16055][hive] Avoid catalog functions when listing Hive built-i…
URL: https://github.com/apache/flink/pull/11093#discussion_r380019248
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV120.java
##########
@@ -148,6 +151,9 @@ public CatalogColumnStatisticsDataDate toFlinkDateColStats(ColumnStatisticsData
@Override
public Optional<FunctionInfo> getBuiltInFunctionInfo(String name) {
+ if (isCatalogFunctionName(name)) {
+ return Optional.empty();
+ }
Optional<FunctionInfo> functionInfo = getFunctionInfo(name);
if (functionInfo.isPresent() && isBuiltInFunctionInfo(functionInfo.get())) {
Review comment:
Since this is a public API, I'd rather not to assume the name has been filtered. I'll do some refactor to avoid duplicated code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services