Re: [PATCH] Store remote host ip on commit

[Blair Zajac <bl...@orcaware.com>]

Sander Striker wrote:
> 
> Hi,
> 
> This patch adds functionality to subversion to obtain
> the ip of the host where a commit is originating from.
> 
> Use 'svnlook ${REPOS} rev ${REV} remotehost' to see where
> a commit came from.  'remotehost' will not be set when
> it couldn't be determined (or when using ra_local).
> 
> It was a question by Eric Gillespie on irc that got me
> to take a peek to see how much effort it was to implement.
> Turned out to be not much effort.
> 
> Thoughts?

What about naming it client_host, commit_host or something like
that.  The host always doesn't have to be remote, and then we
could also record that the commit was from 127.0.0.1 for ra_local
commits so the value is always filled.

For security and debugging purposes, it also may be interesting
to have the client send what it thinks its own IP address is, since
NAT will often times change the IP that the svn server sees.
I don't know if this is too useful.

Best,
Blair

-- 
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Store remote host ip on commit

[Peter Davis <pe...@pdavis.cx>]

On Wednesday 17 July 2002 14:58, Blair Zajac wrote:
> For security and debugging purposes, it also may be interesting
> to have the client send what it thinks its own IP address is

That's kind of anti-security, since the client could be hacked (fairly easily 
since the source is available) to send a bogus IP.  It could be useful for 
debugging though, as long as it was never treated as authoritative.  The 
outside NAT-ed IP would still have to be stored.

-- 
Peter Davis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org