You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/01/03 10:22:27 UTC

[GitHub] flink pull request #5212: [FLINK-8323][table] fix MOD scalar function bug.

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5212#discussion_r159392048
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala ---
    @@ -356,8 +356,117 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       // Math functions
       // ----------------------------------------------------------------------------------------------
     
    +  @Test
    +  def testAdd(): Unit = {
    --- End diff --
    
    Can you move this to `ScalarOperatorsTest`? These +/*/% are core operators.


---