You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by gn...@apache.org on 2026/09/26 17:08:49 UTC
(maven-filtering) branch master updated: fix: remove sensitive property values from debug log output (MRESOURCES-290)
This is an automated email from the ASF dual-hosted git repository.
gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-filtering.git
The following commit(s) were added to refs/heads/master by this push:
new 2ebc736 fix: remove sensitive property values from debug log output (MRESOURCES-290)
2ebc736 is described below
commit 2ebc73618eeac0f20f8d295e202cda5b0419d76e
Author: Guillaume Nodet <gn...@gmail.com>
AuthorDate: Sat Sep 26 19:08:43 2026 +0200
fix: remove sensitive property values from debug log output (MRESOURCES-290)
- Replace full key=value property dump in BaseFilter.getDefaultFilterWrappers() with a count-only message
- Prevents env.* namespace (AWS keys, GitHub tokens, database URLs) from leaking in `mvn -X` debug output
- Retains diagnostic value: count still indicates whether properties were loaded correctly
- Fixes apache/maven-resources-plugin#133 (MRESOURCES-290)
---
src/main/java/org/apache/maven/shared/filtering/BaseFilter.java | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java b/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java
index db75bdc..5f6c953 100644
--- a/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java
+++ b/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java
@@ -27,7 +27,6 @@ import java.util.LinkedHashSet;
import java.util.List;
import java.util.Optional;
import java.util.Properties;
-import java.util.TreeSet;
import java.util.function.Consumer;
import org.apache.maven.api.Project;
@@ -149,10 +148,7 @@ class BaseFilter implements DefaultFilterInfo {
new ArrayList<>(request.getDelimiters().size() + 1);
if (getLogger().isDebugEnabled()) {
- getLogger().debug("properties used:");
- for (String s : new TreeSet<>(filterProperties.stringPropertyNames())) {
- getLogger().debug(s + ": " + filterProperties.getProperty(s));
- }
+ getLogger().debug("number of properties used for filtering: {}", filterProperties.size());
}
final ValueSource propertiesValueSource = new PropertiesBasedValueSource(filterProperties);