[GitHub] [hudi] hotienvu opened a new pull request #2187: [Minor] Make sure factory method is used to instanciate DFSPathSelector

[GitBox <gi...@apache.org>]

hotienvu opened a new pull request #2187:
URL: https://github.com/apache/hudi/pull/2187


   
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Currently we have a way to register custom DFSPathSelector using UtilHelpers.createSourceSelector. However other *DFSSource(except AvroDFSSource) are still calling the constructor. This PR makes sure they use the factory method instead
   
   
   
   ## Brief change log
   * Move createSourceSelector into DFSPathSelector factory method
   * Replace constructor call with factory method for *DFSSource
   * Added some javadoc
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org