You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by jorgebay <gi...@git.apache.org> on 2018/03/20 09:29:46 UTC

[GitHub] tinkerpop issue #820: TINKERPOP-1865 Run Gremlin.Net tests with GraphSON 3.0

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/820
  
    I've rebased this branch to get the fixes for `P.within()` from #817.
    
    Also, I've switched to use a lambda (now that we support it :) ) to obtain all the edges for the scenario data, that way we use the same traversal as Python. It would be nice to backport the same traversal for `tp32` but it's not necessary for now.
    
    About `g_VX1X_hasXlabel_personX_mapXmapXint_ageXX_orderXlocalX_byXvalues_decrX_byXkeys_incrX`, I've changed the lambda to return a `Map<string, int>`.
    
    Regarding `g_V_storeXaX_byXoutEXcreatedX_countX_out_out_storeXaX_byXinEXcreatedX_weight_sumX`, its still ignored as the returned data doesn't match, it returns:
    
    ```javascript
    { '@type': 'g:Set',
      '@value': 
       [ { '@type': 'g:Int64', '@value': 1 },
         { '@type': 'g:Int64', '@value': 1 },
         { '@type': 'g:Int64', '@value': 0 },
         { '@type': 'g:Int64', '@value': 0 },
         { '@type': 'g:Int64', '@value': 0 },
         { '@type': 'g:Int64', '@value': 2 },
         { '@type': 'g:Double', '@value': 1 },
         { '@type': 'g:Double', '@value': 1 }
    ```
    
    Which is deserialized into a `Set<object>` containing only the different values (4 values in total), so it's a scenario design issue (not related to Gremlin.NET).
    
    @FlorianHockmann I hope you don't mind that I've directly pushed to the dev branch, feel free to revert the commits if needed.


---