You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/15 22:49:13 UTC
[jira] [Commented] (TAJO-1247) Store type 'TEXTFILE' should be TEXT
while keeping enum 'TEXTFILE' in protobuf
[ https://issues.apache.org/jira/browse/TAJO-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247280#comment-14247280 ]
ASF GitHub Bot commented on TAJO-1247:
--------------------------------------
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/302
TAJO-1247: Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf
Recently, we added TEXTFILE for all kinds line-delimited plan text files. But, its name is long and is different to naming convention that we've used. So, I propose renaming it to TEXT. But, TEXT is equivalent to the data domain 'TEXT', so we should keep its enum type in CatalogProtos.proto.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/TAJO-1247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #302
----
commit eb7370e3e4ae79104f9a98d890c0f0a3747c7523
Author: clark.kang <cl...@kakao.com>
Date: 2014-12-15T21:35:19Z
TAJO-1247 using text in only sql
----
> Store type 'TEXTFILE' should be TEXT while keeping enum 'TEXTFILE' in protobuf
> ------------------------------------------------------------------------------
>
> Key: TAJO-1247
> URL: https://issues.apache.org/jira/browse/TAJO-1247
> Project: Tajo
> Issue Type: Improvement
> Reporter: Hyunsik Choi
> Assignee: DaeMyung Kang
> Fix For: 0.9.1
>
>
> Recently, we added TEXTFILE for all kinds line-delimited plan text files. But, its name is long and is different to naming convention that we've used. So, I propose renaming it to TEXT. But, TEXT is equivalent to the data domain 'TEXT', so we should keep its enum type in CatalogProtos.proto.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)