You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (JIRA)" <ji...@apache.org> on 2012/10/04 21:53:48 UTC

[jira] [Updated] (HBASE-6949) Automatically delete empty directories in CleanerChore

     [ https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Yates updated HBASE-6949:
-------------------------------

    Attachment: hbase-6949-v0.patch

Attaching patch to refactor CleanerChore to accommodate the above description. The refactor is pretty minor - mostly just a cleaner version of what's there already. 

However, I took the time to throw a couple of tests in there to cover the current functionality, rather than having subclasses inherently test that functionaliy.
                
> Automatically delete empty directories in CleanerChore
> ------------------------------------------------------
>
>                 Key: HBASE-6949
>                 URL: https://issues.apache.org/jira/browse/HBASE-6949
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: hbase-6949-v0.patch
>
>
> Currently the CleanerChore asks cleaner delegates if both directories and files should be deleted. However, this leads to somewhat odd behavior in some delegates - you don't actually care if the directory hierarchy is preserved, the files; this means you always will delete directories and then implement the logic you actually want for preserving files. Instead we can handle this logic one layer higher in the CleanerChore and let the delegates just worry about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira