You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/16 12:23:20 UTC

[GitHub] [couchdb] KangTheTerrible opened a new pull request #3428: WIP: Support uri_file write for chttpd

KangTheTerrible opened a new pull request #3428:
URL: https://github.com/apache/couchdb/pull/3428


   ## Overview
   
   The uri_file config parameter was not supported in the switch to chttpd. Pulling the relevant section of code in from couch_sup.erl.
   
   ## Testing recommendations
   Booting up couchdb with specific cluster port set and port 0. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd merged pull request #3428: Support uri_file write for chttpd

Posted by GitBox <gi...@apache.org>.
bessbd merged pull request #3428:
URL: https://github.com/apache/couchdb/pull/3428


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3428: Support uri_file write for chttpd

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3428:
URL: https://github.com/apache/couchdb/pull/3428#issuecomment-809525032


   @janl : should we merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] janl commented on pull request #3428: WIP: Support uri_file write for chttpd

Posted by GitBox <gi...@apache.org>.
janl commented on pull request #3428:
URL: https://github.com/apache/couchdb/pull/3428#issuecomment-801078137


   > This duplicated block of code still exists in couch_sup.erl and I feel it should be removed.
   
   +1
   
   the rest looks good, well done :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] janl commented on pull request #3428: Support uri_file write for chttpd

Posted by GitBox <gi...@apache.org>.
janl commented on pull request #3428:
URL: https://github.com/apache/couchdb/pull/3428#issuecomment-817817743


   @bessbd yes :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3428: Support uri_file write for chttpd

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3428:
URL: https://github.com/apache/couchdb/pull/3428#issuecomment-817822175


   Thank you for the patch, @KangTheTerrible and thank you for the review, @janl ! I'm about to merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] KangTheTerrible commented on pull request #3428: WIP: Support uri_file write for chttpd

Posted by GitBox <gi...@apache.org>.
KangTheTerrible commented on pull request #3428:
URL: https://github.com/apache/couchdb/pull/3428#issuecomment-800232926


   This duplicated block of code still exists in couch_sup.erl and I feel it should be removed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org