You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "IsmoLeszczynski (via GitHub)" <gi...@apache.org> on 2025/04/09 11:34:13 UTC
[PR] Fix discrete input handling when processing response
IsmoLeszczynski opened a new pull request, #2055:
URL: https://github.com/apache/plc4x/pull/2055
Like the Coils, Discrete Inputs are also handled like single bits. The current implementation tried to handle them like Registers, which caused issues when the response consisted of a single byte instead of two. This solution merges the handling of Coils and Discrete Inputs as they're technically identical in this respect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(plc4j/modbus): ModbusOptimizer fixes for discrete-input and endianness
Posted by "sruehl (via GitHub)" <gi...@apache.org>.
sruehl merged PR #2055:
URL: https://github.com/apache/plc4x/pull/2055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(plc4j/modbus): ModbusOptimizer fixes for discrete-input and endianness
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #2055:
URL: https://github.com/apache/plc4x/pull/2055#issuecomment-2846528173
It does ... haven't had the chance to have a detailed look at it. But as I have never used the discrete-inputs anyway, I'll probably not get to doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(plc4j/modbus): Fix discrete input handling when processing response
Posted by "IsmoLeszczynski (via GitHub)" <gi...@apache.org>.
IsmoLeszczynski commented on PR #2055:
URL: https://github.com/apache/plc4x/pull/2055#issuecomment-2809046169
Updated PR to include also a fix for #2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(plc4j/modbus): ModbusOptimizer fixes for discrete-input and endianness
Posted by "sruehl (via GitHub)" <gi...@apache.org>.
sruehl commented on PR #2055:
URL: https://github.com/apache/plc4x/pull/2055#issuecomment-2846511151
LGTM, WDYT @chrisdutz?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org