[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8779: Handle missing values for delimited text files when Nullhandling is enabled

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8779: Handle missing values for delimited text files when Nullhandling is enabled
URL: https://github.com/apache/incubator-druid/pull/8779#discussion_r348301739
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/query/MultiValuedDimensionTest.java
 ##########
 @@ -161,7 +161,7 @@ public void setup() throws Exception
         "2011-01-12T00:00:00.000Z,product_1,t1\tt2\tt3,u1\tu2",
         "2011-01-13T00:00:00.000Z,product_2,t3\tt4\tt5,u3\tu4",
         "2011-01-14T00:00:00.000Z,product_3,t5\tt6\tt7,u1\tu5",
-        "2011-01-14T00:00:00.000Z,product_4,,u2"
+        "2011-01-14T00:00:00.000Z,product_4,\"\",u2"
 
 Review comment:
   I think this is to preserve the original test, since previously csv parser would always produce empty strings here, but after this change in null compatible mode it will produce a null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org