You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/07 06:24:47 UTC

[GitHub] piiswrong commented on a change in pull request #10021: [MXNET-33] Mkldnn pooling convention crash

piiswrong commented on a change in pull request #10021: [MXNET-33] Mkldnn pooling convention crash
URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r172750399
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
 ##########
 @@ -92,6 +92,8 @@ inline bool SupportMKLDNNPooling(const PoolingParam &param,
 
   if (param.pooling_convention == pool_enum::kValid)
     return true;
+  else
+    return false;
 
 Review comment:
   this makes the later code unreachable. Are you sure this is what you want?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services