You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/10/08 23:08:33 UTC
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14392
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
---
M docs/topics/impala_client.xml
1 file changed, 42 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14392/1
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/513/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 02:28:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml
File docs/topics/impala_client.xml:
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@226
PS1, Line 226: --hs2_http_port
Maybe note somewhere the default is 28000
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@281
PS1, Line 281: --max_cookie_lifetime_s
Maybe note somewhere the default is 1 day.
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@285
PS1, Line 285: 3.40
3.4.0?
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@285
PS1, Line 285: accepts
nit: maybe "uses"?
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 00:53:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/510/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 23:35:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Reviewed-on: http://gerrit.cloudera.org:8080/14392
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M docs/topics/impala_client.xml
1 file changed, 55 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Thomas Tauber-Marshall: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14392
to look at the new patch set (#3).
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
---
M docs/topics/impala_client.xml
1 file changed, 55 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14392/3
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/516/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2019 18:43:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/513/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 01:03:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/510/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 23:08:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14392
to look at the new patch set (#2).
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
---
M docs/topics/impala_client.xml
1 file changed, 50 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14392/2
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml
File docs/topics/impala_client.xml:
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@226
PS1, Line 226: --hs2_http_port
> Maybe note somewhere the default is 28000
Done
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@281
PS1, Line 281: --max_cookie_lifetime_s
> Maybe note somewhere the default is 1 day.
So, 1 day in second is the default value?
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@285
PS1, Line 285: 3.40
> 3.4.0?
Done
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@285
PS1, Line 285: accepts
> nit: maybe "uses"?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 01:03:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2019 20:45:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml
File docs/topics/impala_client.xml:
http://gerrit.cloudera.org:8080/#/c/14392/1/docs/topics/impala_client.xml@281
PS1, Line 281: <dlentry>
> So, 1 day in second is the default value?
Yep
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 01:41:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14392 )
Change subject: IMPALA-8893: [DOCS] Document the new startup flag for cookie-based authn
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/516/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd43430363839ae41e490cd35c92e77e6610f4f
Gerrit-Change-Number: 14392
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2019 18:37:21 +0000
Gerrit-HasComments: No