You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/13 07:22:04 UTC
[GitHub] [pulsar] hnail opened a new pull request #8246: JAVA client support UnAvroBasedSchema
hnail opened a new pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246
### Motivation
JAVA client support UnAvroBasedSchema
### Modifications
- `schema` division to **AvroBasedSchema** and **UnAvroBasedSchema** :
- AvroBasedStructSchema vs StructSchema
- GenericSchemaImpl vs AbstractGenericSchema
- `GenericSchema` add `of()` method , `GenericSchemaImpl` continue to have for backward compatibility and only support AvroBasedGenericSchema 。
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no )
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation (yes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail commented on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
hnail commented on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-709949395
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail commented on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
hnail commented on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-716952252
> @hnail The change looks great to me! It is a great refactor to support both AvroBased and UnAvroBased schemas. Thank you for your contributions!
thank for your review ，I have commit a UnAvroBasedSchema `ProtobufNative` [PIP-Add ProtobufNative Schema Support](https://docs.google.com/document/d/1XR_MNOuSXyig-CKsdVhr6IXvFwziBRdSoS3oEUiLFe8/edit) and [PR-8372](https://github.com/apache/pulsar/pull/8372) which depends this PR. cc @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail edited a comment on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
hnail edited a comment on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-716952252
> @hnail The change looks great to me! It is a great refactor to support both AvroBased and UnAvroBased schemas. Thank you for your contributions!
Thank for your review ，I have commit a UnAvroBasedSchema `ProtobufNative` [PIP-Add ProtobufNative Schema Support](https://docs.google.com/document/d/1XR_MNOuSXyig-CKsdVhr6IXvFwziBRdSoS3oEUiLFe8/edit) and [PR-8372](https://github.com/apache/pulsar/pull/8372) which depends this PR. cc @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-716502407
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail commented on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
hnail commented on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-708867033
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail removed a comment on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
hnail removed a comment on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-708867033
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-751991477
Confirmed w/ @congbobo184, no need to update doc for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-713316512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail edited a comment on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
hnail edited a comment on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-716952252
> @hnail The change looks great to me! It is a great refactor to support both AvroBased and UnAvroBased schemas. Thank you for your contributions!
Thank for your review ，I have commit a UnAvroBasedSchema `ProtobufNative`<[PIP-Add ProtobufNative Schema Support](https://docs.google.com/document/d/1XR_MNOuSXyig-CKsdVhr6IXvFwziBRdSoS3oEUiLFe8/edit)> and [PR-8372](https://github.com/apache/pulsar/pull/8372) which depends this PR. cc @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail commented on pull request #8246: JAVA client support UnAvroBasedSchema
Posted by GitBox <gi...@apache.org>.
hnail commented on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-708330265
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hnail edited a comment on pull request #8246: [Client] java client support UnAvroBased Schema
Posted by GitBox <gi...@apache.org>.
hnail edited a comment on pull request #8246:
URL: https://github.com/apache/pulsar/pull/8246#issuecomment-716952252
> @hnail The change looks great to me! It is a great refactor to support both AvroBased and UnAvroBased schemas. Thank you for your contributions!
Thank for your review ，I have commit a UnAvroBasedSchema `ProtobufNative`< [PIP-Add ProtobufNative Schema Support](https://docs.google.com/document/d/1XR_MNOuSXyig-CKsdVhr6IXvFwziBRdSoS3oEUiLFe8/edit) > and [PR-8372](https://github.com/apache/pulsar/pull/8372) which depends this PR. cc @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org