You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 22:56:50 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request #10535: Add update mask to stable REST API patch dag endpoint

ephraimbuddy opened a new pull request #10535:
URL: https://github.com/apache/airflow/pull/10535


   This PR adds an update mask to patch dag endpoint. 
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10535: Add update mask to stable REST API patch dag endpoint

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10535:
URL: https://github.com/apache/airflow/pull/10535#issuecomment-679961900


   > Cool. I still think that it is worth adding a description of the update_mask parameter in the API introduction. Would you like to take care of it?
   
   Ok. I will create a PR on it tonight :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj merged pull request #10535: Add update mask to stable REST API patch dag endpoint

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #10535:
URL: https://github.com/apache/airflow/pull/10535


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #10535: Add update mask to stable REST API patch dag endpoint

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10535:
URL: https://github.com/apache/airflow/pull/10535#issuecomment-679954668


   Cool. I still think that it is worth adding a description of the update_mask parameter in the API introduction. Would you like to take care of it?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #10535: Add update mask to stable REST API patch dag endpoint

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10535:
URL: https://github.com/apache/airflow/pull/10535#issuecomment-680311249


   @ephraimbuddy  I added introduction to API, so your change will be much easier now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #10535: Add update mask to stable REST API patch dag endpoint

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10535:
URL: https://github.com/apache/airflow/pull/10535#issuecomment-680314223


   That's awesome. Currently resolving a lot of conflicts in the other PR about unifying API errors but I have pushed the update mask change, haven't created the PR yet. Will create it this night


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org