You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/22 08:20:42 UTC
[GitHub] [arrow] AlenkaF opened a new pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
AlenkaF opened a new pull request #12483:
URL: https://github.com/apache/arrow/pull/12483
This PR is a proposal to rearrange the existing [contributing page](https://arrow.apache.org/docs/developers/contributing.html) to serve as a landing page for topics connected to contribution to Apache Arrow. Main topics are as follows:
- Community
- New Contributor's Guide
- Advanced code contribution
- Report bugs and propose features
<details>
<summary>Click to see the html view of the landing page:</summary>
</details>
The existing content was transferred to two new pages (_bug_reports.rst_, _advanced.rst_) and to existing section of the New Contributors Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r832987046
##########
File path: docs/source/conf.py
##########
@@ -277,7 +278,8 @@
html_static_path = ['_static']
# Custom fixes to the RTD theme
-html_css_files = ['theme_overrides.css']
+html_css_files = ['theme_overrides.css',
+ 'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css']
Review comment:
Ok, I understand. Will try without and see what happens ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1073676132
Yes, if the icons can be downloaded for free, we do not need a licence. The ones I selected are free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r832509260
##########
File path: docs/source/conf.py
##########
@@ -277,7 +278,8 @@
html_static_path = ['_static']
# Custom fixes to the RTD theme
-html_css_files = ['theme_overrides.css']
+html_css_files = ['theme_overrides.css',
+ 'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css']
Review comment:
Is this needed if you included the svg files itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Finished :arrow_down:0.67% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/403| `7de798a0` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/389| `7de798a0` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/399| `7de798a0` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/402| `6773da12` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/388| `6773da12` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/388| `6773da12` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/398| `6773da12` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1072241362
@thisisnic no, I don't think we have a licence for Pro images but I have included only free versions and that should be fine. See https://fontawesome.com/plans under **Open Source Icons** "A solid set of icons safe for use in open source projects" near the bottom of the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #12483:
URL: https://github.com/apache/arrow/pull/12483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Finished :arrow_down:0.67% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1075986928
Yes, I would need to clarify better.
For free downloadable icons it is stated that these are "A solid set of icons safe for use in open source projects." plus the paragraph you added, Joris, add the info about attribution.
From this I concluded that the icons, I am able to download for free, are OK to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r829231363
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
+
+ .. code-block:: R
+
+ library(arrow)
+ #>
+ #> Attaching package: 'arrow'
+ #> The following object is masked from 'package:utils':
+ #>
+ #> timestamp
+ tf <- tempfile()
+ write.csv(data.frame(x = '2018-10-07 19:04:05.005'), tf, row.names = FALSE)
+
+ # successfully read in file
+ read_csv_arrow(tf, as_data_frame = TRUE)
+ #> # A tibble: 1 × 1
+ #> x
+ #> <dttm>
+ #> 1 2018-10-07 20:04:05
+
+ # the unit here is seconds - doesn't work
+ read_csv_arrow(
+ tf,
+ col_names = "x",
+ col_types = "T",
+ skip = 1
+ )
+ #> Error in `handle_csv_read_error()`:
+ #> ! Invalid: In CSV column #0: CSV conversion error to timestamp[s]: invalid value '2018-10-07 19:04:05.005'
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:550 decoder_.Decode(data, size, quoted, &value)
+ #> /home/nic2/arrow/cpp/src/arrow/csv/parser.h:123 status
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:554 parser.VisitColumn(col_index, visit)
Review comment:
```suggestion
#> ! Invalid: In CSV column #0: CSV conversion error to timestamp[s]: invalid value '2018-10-07 19:04:05.005'
```
Trimming the extra bits of error message that wouldn't be here for users who haven't set the environment variable `ARROW_R_DEV` to `TRUE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r829233079
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
+
+ .. code-block:: R
+
+ library(arrow)
+ #>
+ #> Attaching package: 'arrow'
+ #> The following object is masked from 'package:utils':
+ #>
+ #> timestamp
Review comment:
```suggestion
library(arrow, warn.conflicts = FALSE)
```
Just tidying up a bit of extra unnecessary output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r832900330
##########
File path: docs/source/conf.py
##########
@@ -277,7 +278,8 @@
html_static_path = ['_static']
# Custom fixes to the RTD theme
-html_css_files = ['theme_overrides.css']
+html_css_files = ['theme_overrides.css',
+ 'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css']
Review comment:
It's needed for the dropdown in _contributing.rst_ - but I can just as well omit the icons (and this fix in the theme) in both dropdowns, will be fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Finished :arrow_down:0.67% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/403| `7de798a0` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/389| `7de798a0` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/389| `7de798a0` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/399| `7de798a0` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/402| `6773da12` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/388| `6773da12` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/388| `6773da12` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/398| `6773da12` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Finished :arrow_down:0.67% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/403| `7de798a0` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/389| `7de798a0` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/399| `7de798a0` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/402| `6773da12` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/388| `6773da12` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/398| `6773da12` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1073660251
> @thisisnic no, I don't think we have a licence for Pro images but I have included only free versions and that should be fine. See https://fontawesome.com/plans under **Open Source Icons** "A solid set of icons safe for use in open source projects" near the bottom of the page.
I'm not sure that that quote means that we can use those icons without a license, but the fact that you've only used the free ones means that it's all good anyway. Glad we can use them as these look great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r829254003
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
Review comment:
```suggestion
Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"`` when source data is in millisecond precision:
```
I reckon that bug title could be even better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Finished :arrow_down:0.67% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Finished :arrow_down:0.67% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Failed :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Finished :arrow_down:0.09% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/403| `7de798a0` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/389| `7de798a0` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/389| `7de798a0` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/399| `7de798a0` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/402| `6773da12` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/388| `6773da12` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/388| `6773da12` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/398| `6773da12` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline = 6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender = 7de798a0bb120920553f1bef3b05dfc6637c0f7a. 7de798a0bb120920553f1bef3b05dfc6637c0f7a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5c8fbdf9a6644f10a8271b4e5f17bfc5...180cb19bb44042099d38d0ec832ec0e1/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2b2d6450c96c4ec2a223dfedbbef8bdd...730d2af0fa8f41739bade855b5a5682f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8e5eaba684241f3b8d64fb83d7a208f...6e1dd9efb43a41f4aea4aae55264a7ad/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/86c7807b5cba49cc996dcbeea0684519...edc83b3a4fb24c8dad06d1b3c5f5d192/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1047535282
https://issues.apache.org/jira/browse/ARROW-15349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r829212895
##########
File path: docs/source/developers/guide/step_by_step/finding_issues.rst
##########
@@ -64,57 +67,88 @@ you will see:
How to create a JIRA issue
==========================
-After creating an account you can click **Create an issue** and select **Apache Arrow project**
-and **Type** of the issue (Bug, Feature, …).
+After creating an account you can click **Create an issue** and select
+**Apache Arrow project** and **Type** of the issue (Bug, Feature, …).
-.. figure:: jira_create_issue.jpeg
+.. figure:: /developers/images/jira_create_issue.jpeg
:scale: 70 %
:alt: creating JIRA issue
The window to create a JIRA issue.
-If you are already in JIRA dashboard click the red ``create`` button in the top to do the same.
+If you are already in JIRA dashboard click the red ``create`` button in
+the top to do the same.
-You are ready to create the issue! Add a title and a description following the
-:ref:`tips for using JIRA <jira-tips>` and you are ready to go!
+You are ready to create the issue! Add a title and a description following
+the :ref:`tips for using JIRA <jira-tips>` and you are ready to go!
.. seealso::
:ref:`Tips for using JIRA <jira-tips>`
You don’t need any special permissions on JIRA to be able to create issues.
-Once you are more involved in the project and want to do more on JIRA, for example assigning
-yourself an issue, you will need **“Contributor” permissions**. To get this role, ask on the
-:ref:`mailing_list` or in the comment of the JIRA issue you created.
+Once you are more involved in the project and want to do more on JIRA, for
+example assigning yourself an issue, you will need **“Contributor” permissions**.
+To get this role, ask on the :ref:`mailing_list` or in the comment of the JIRA
+issue you created.
-When the ticket is created you can start a discussion about it in the JIRA comments section.
+When the ticket is created you can start a discussion about it in the
+JIRA comments section.
How we use JIRA to find an issue
================================
-To make it easier for you to find issues that are well-suited for new contributors, we have added labels
-like “good-first-issue” or “beginner” to some JIRA tickets.
+To make it easier for you to find issues that are well-suited for new
+contributors, we have added labels like “good-first-issue” or “beginner”
+to some JIRA tickets.
.. seealso::
- Search for good first/second issues with labels like in the `link here
- <https://issues.apache.org/jira/issues/?filter=-4&jql=project%20%3D%20ARROW%20AND%20status%20%3D%20Open%20AND%20labels%20in%20(Beginner%2C%20beginner%2C%20beginners%2C%20beginnner%2C%20beginner-friendly%2C%20good-first-issue%2C%20good-second-issue%2C%20GoodForNewContributors%2C%20newbie%2C%20easyfix%2C%20documentation)%20order%20by%20created%20DESC>`_
+ Search for good first/second issues with labels like in the `link here
+ <https://issues.apache.org/jira/issues/?filter=-4&jql=project%20%3D%20ARROW%20AND%20status%20%3D%20Open%20AND%20labels%20in%20(Beginner%2C%20beginner%2C%20beginners%2C%20beginnner%2C%20beginner-friendly%2C%20good-first-issue%2C%20good-second-issue%2C%20GoodForNewContributors%2C%20newbie%2C%20easyfix%2C%20documentation)%20order%20by%20created%20DESC>`_
-The issues labeled as good first issues should take no more than two days or a weekend to
-fix them. Once you dig into the code you may find that the issue is not easy at all - this can
-happen as the problem could be harder than the person who triaged the ticket expected it to be.
-Don't hesitate to write that in the comments.
+The issues labeled as good first issues should take no more than two days or
+a weekend to fix them. Once you dig into the code you may find that the issue
+is not easy at all - this can happen as the problem could be harder than the
+person who triaged the ticket expected it to be. Don't hesitate to write that
+in the comments.
-.. figure:: jira_good_first_issue.jpeg
+.. figure:: /developers/images/jira_good_first_issue.jpeg
:scale: 45 %
:alt: finding good first JIRA issue
Example of the list of good first issues.
.. note::
- When you find a JIRA issue you would like to work on, please mention your interest in the comment
- section of that issue; that way we will know you are working on it.
+
+ When you find a JIRA issue you would like to work on, please mention your
+ interest in the comment section of that issue; that way we will know you
+ are working on it.
Also, do not hesitate to ask questions in the comment section of the issue.
You can get some pointers about where to start and similar issues already solved.
-**Do not forget to create a new branch once you have created or chosen an issue you will be
-working on!** Follow the instructions in the :ref:`pr_lifecycle` section or follow the next section: :ref:`arrow-codebase`.
+**What if an issue is already asigned?**
+Anything that’s not in the “In Progress” state is fair game, even if it is
+“Assigned” to someone, particularly if it has not been recently updated.
+When in doubt, comment on the issue asking if they mind if you try to put
+together a pull request; interpret no response to mean that you’re free to
+proceed.
+
+**Aske questions**
Review comment:
```suggestion
**Ask questions**
```
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
+
+ .. code-block:: R
+
+ library(arrow)
+ #>
+ #> Attaching package: 'arrow'
+ #> The following object is masked from 'package:utils':
+ #>
+ #> timestamp
+ tf <- tempfile()
+ write.csv(data.frame(x = '2018-10-07 19:04:05.005'), tf, row.names = FALSE)
+
+ # successfully read in file
+ read_csv_arrow(tf, as_data_frame = TRUE)
+ #> # A tibble: 1 × 1
+ #> x
+ #> <dttm>
+ #> 1 2018-10-07 20:04:05
+
+ # the unit here is seconds - doesn't work
+ read_csv_arrow(
+ tf,
+ col_names = "x",
+ col_types = "T",
+ skip = 1
+ )
+ #> Error in `handle_csv_read_error()`:
+ #> ! Invalid: In CSV column #0: CSV conversion error to timestamp[s]: invalid value '2018-10-07 19:04:05.005'
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:550 decoder_.Decode(data, size, quoted, &value)
+ #> /home/nic2/arrow/cpp/src/arrow/csv/parser.h:123 status
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:554 parser.VisitColumn(col_index, visit)
Review comment:
```suggestion
#> ! Invalid: In CSV column #0: CSV conversion error to timestamp[s]: invalid value '2018-10-07 19:04:05.005'
```
Trimming the extra bits of error message that wouldn't be here for users who haven't set the environment variable `ARROW_R_DEV` to `TRUE`
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
+
+ .. code-block:: R
+
+ library(arrow)
+ #>
+ #> Attaching package: 'arrow'
+ #> The following object is masked from 'package:utils':
+ #>
+ #> timestamp
+ tf <- tempfile()
+ write.csv(data.frame(x = '2018-10-07 19:04:05.005'), tf, row.names = FALSE)
+
+ # successfully read in file
+ read_csv_arrow(tf, as_data_frame = TRUE)
+ #> # A tibble: 1 × 1
+ #> x
+ #> <dttm>
+ #> 1 2018-10-07 20:04:05
+
+ # the unit here is seconds - doesn't work
+ read_csv_arrow(
+ tf,
+ col_names = "x",
+ col_types = "T",
+ skip = 1
+ )
+ #> Error in `handle_csv_read_error()`:
+ #> ! Invalid: In CSV column #0: CSV conversion error to timestamp[s]: invalid value '2018-10-07 19:04:05.005'
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:550 decoder_.Decode(data, size, quoted, &value)
+ #> /home/nic2/arrow/cpp/src/arrow/csv/parser.h:123 status
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:554 parser.VisitColumn(col_index, visit)
+
+ # the unit here is ms - doesn't work
+ read_csv_arrow(
+ tf,
+ col_names = "x",
+ col_types = "t",
+ skip = 1
+ )
+ #> Error in `handle_csv_read_error()`:
+ #> ! Invalid: In CSV column #0: CSV conversion error to time32[ms]: invalid value '2018-10-07 19:04:05.005'
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:550 decoder_.Decode(data, size, quoted, &value)
+ #> /home/nic2/arrow/cpp/src/arrow/csv/parser.h:123 status
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:554 parser.VisitColumn(col_index, visit)
Review comment:
```suggestion
#> ! Invalid: In CSV column #0: CSV conversion error to time32[ms]: invalid value '2018-10-07 19:04:05.005'
```
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
+
+ .. code-block:: R
+
+ library(arrow)
+ #>
+ #> Attaching package: 'arrow'
+ #> The following object is masked from 'package:utils':
+ #>
+ #> timestamp
Review comment:
```suggestion
library(arrow, warn.conflicts = FALSE)
```
Just tidying up a bit of extra unnecessary output.
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
Review comment:
```suggestion
Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"`` when source data is in millisecond precision:
```
I reckon that bug title could be even better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r832995636
##########
File path: docs/source/conf.py
##########
@@ -277,7 +278,8 @@
html_static_path = ['_static']
# Custom fixes to the RTD theme
-html_css_files = ['theme_overrides.css']
+html_css_files = ['theme_overrides.css',
+ 'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css']
Review comment:
It finds `hand-point-up` but not the `pencil` icon 🤦♀️
Looking at it I see is actually nicer without the icons in the dropdown so I will remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1075498266
> Yes, if the icons can be downloaded for free, we do not need a licence.
Theoretically, it's not because it is free / open source, that it might not be required to include the license if you copy some files (eg when we vendor another library in Arrow, we also include its license).
Now, checking the github repo, it has https://github.com/FortAwesome/Font-Awesome#license, which indicates the svg files are CC BY, which requires attribution, but there is also this paragraph:
> Downloaded Font Awesome Free files already contain embedded comments with sufficient attribution, so you shouldn't need to do anything additional when using these files normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r829231830
##########
File path: docs/source/developers/bug_reports.rst
##########
@@ -0,0 +1,206 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agreements. See the NOTICE file
+.. distributed with this work for additional information
+.. regarding copyright ownership. The ASF licenses this file
+.. to you under the Apache License, Version 2.0 (the
+.. "License"); you may not use this file except in compliance
+.. with the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing,
+.. software distributed under the License is distributed on an
+.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+.. KIND, either express or implied. See the License for the
+.. specific language governing permissions and limitations
+.. under the License.
+
+.. _bug-reports:
+
+********************************
+Report bugs and propose features
+********************************
+
+Using the software and sharing your experience is a very helpful contribution
+itself. Those who actively develop Arrow need feedback from users on what
+works and what doesn't. Alerting us to unexpected behavior and missing features,
+even if you can't solve the problems yourself, help us understand and prioritize
+work to improve the libraries.
+
+We use `JIRA <https://issues.apache.org/jira/projects/ARROW/issues>`_
+to manage our development "todo" list and to maintain changelogs for releases.
+In addition, the project's `Confluence site <https://cwiki.apache.org/confluence/display/ARROW>`_
+has some useful higher-level views of the JIRA issues.
+
+To create a JIRA issue, you'll need to have an account on the ASF JIRA, which
+you can `sign yourself up for <https://issues.apache.org/jira/secure/Signup!default.jspa>`_.
+The JIRA server hosts bugs and issues for multiple Apache projects. The JIRA
+project name for Arrow is "ARROW".
+
+You don't need any special permissions on JIRA to be able to create issues.
+Once you are more involved in the project and want to do more on JIRA, such as
+assign yourself an issue, you will need "Contributor" permissions on the
+Apache Arrow JIRA. To get this role, ask on the mailing list for a project
+maintainer's help.
+
+
+.. _jira-tips:
+
+Tips for using JIRA
+===================
+
+Before you create a new issue, we recommend you first
+`search <https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20resolution%20%3D%20Unresolved>`_
+among existing Arrow issues.
+
+When reporting a new issue, follow these conventions to help make sure the
+right people see it:
+
+* Use the **Component** field to indicate the area of the project that your
+ issue pertains to (for example "Python" or "C++").
+* Also prefix the issue title with the component name in brackets, for example
+ ``[Python] issue name`` ; this helps when navigating lists of open issues,
+ and it also makes our changelogs more readable. Most prefixes are exactly the
+ same as the **Component** name, with the following exceptions:
+
+ * **Component:** Continuous Integration — **Summary prefix:** [CI]
+ * **Component:** Developer Tools — **Summary prefix:** [Dev]
+ * **Component:** Documentation — **Summary prefix:** [Docs]
+
+* If you're reporting something that used to work in a previous version
+ but doesn't work in the current release, you can add the "Affects version"
+ field. For feature requests and other proposals, "Affects version" isn't
+ appropriate.
+
+Project maintainers may later tweak formatting and labels to help improve their
+visibility. They may add a "Fix version" to indicate that they're considering
+it for inclusion in the next release, though adding that tag is not a
+commitment that it will be done in the next release.
+
+.. _bug-report-tips:
+
+Tips for successful bug reports
+================================
+
+No one likes having bugs in their software, and in an ideal world, all bugs
+would get fixed as soon as they were reported. However, time and attention are
+finite, especially in an open-source project where most contributors are
+participating in their spare time. All contributors in Apache projects are
+volunteers and act as individuals, even if they are contributing to the project
+as part of their job responsibilities.
+
+In order for your bug to get prompt
+attention, there are things you can do to make it easier for contributors to
+reproduce and fix it.
+**When you're reporting a bug, please help us understand the issue by providing,
+to the best of your ability,**
+
+* **Clear, minimal steps to reproduce the issue, with as few non-Arrow
+ dependencies as possible.** If there's a problem on reading a file, try to
+ provide as small of an example file as possible, or code to create one.
+ If your bug report says "it crashes trying to read my file, but I can't
+ share it with you," it's really hard for us to debug.
+* Any relevant operating system, language, and library version information
+* If it isn't obvious, clearly state the expected behavior and what actually
+ happened.
+
+If a developer can't get a failing unit test, they won't be able to know that
+the issue has been identified, and they won't know when it has been fixed.
+Try to anticipate the questions you might be asked by someone working to
+understand the issue and provide those supporting details up front.
+
+Good reproducible examples or minimal bug reports can be found in next tabs:
+
+.. tabs::
+
+ .. tab:: Python
+
+ The ``print`` method of a timestamp with timezone errors:
+
+ .. code-block:: python
+
+ import pyarrow as pa
+
+ a = pa.array([0], pa.timestamp('s', tz='+02:00'))
+
+ print(a) # representation not correct?
+ # <pyarrow.lib.TimestampArray object at 0x7f834c7cb9a8>
+ # [
+ # 1970-01-01 00:00:00
+ # ]
+
+ print(a[0])
+ #Traceback (most recent call last):
+ # File "<stdin>", line 1, in <module>
+ # File "pyarrow/scalar.pxi", line 80, in pyarrow.lib.Scalar.__repr__
+ # File "pyarrow/scalar.pxi", line 463, in pyarrow.lib.TimestampScalar.as_py
+ # File "pyarrow/scalar.pxi", line 393, in pyarrow.lib._datetime_from_int
+ #ValueError: fromutc: dt.tzinfo is not self
+
+ .. tab:: R
+
+ Error when reading a CSV file with ``col_types`` option ``"T"`` or ``"t"``:
+
+ .. code-block:: R
+
+ library(arrow)
+ #>
+ #> Attaching package: 'arrow'
+ #> The following object is masked from 'package:utils':
+ #>
+ #> timestamp
+ tf <- tempfile()
+ write.csv(data.frame(x = '2018-10-07 19:04:05.005'), tf, row.names = FALSE)
+
+ # successfully read in file
+ read_csv_arrow(tf, as_data_frame = TRUE)
+ #> # A tibble: 1 × 1
+ #> x
+ #> <dttm>
+ #> 1 2018-10-07 20:04:05
+
+ # the unit here is seconds - doesn't work
+ read_csv_arrow(
+ tf,
+ col_names = "x",
+ col_types = "T",
+ skip = 1
+ )
+ #> Error in `handle_csv_read_error()`:
+ #> ! Invalid: In CSV column #0: CSV conversion error to timestamp[s]: invalid value '2018-10-07 19:04:05.005'
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:550 decoder_.Decode(data, size, quoted, &value)
+ #> /home/nic2/arrow/cpp/src/arrow/csv/parser.h:123 status
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:554 parser.VisitColumn(col_index, visit)
+
+ # the unit here is ms - doesn't work
+ read_csv_arrow(
+ tf,
+ col_names = "x",
+ col_types = "t",
+ skip = 1
+ )
+ #> Error in `handle_csv_read_error()`:
+ #> ! Invalid: In CSV column #0: CSV conversion error to time32[ms]: invalid value '2018-10-07 19:04:05.005'
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:550 decoder_.Decode(data, size, quoted, &value)
+ #> /home/nic2/arrow/cpp/src/arrow/csv/parser.h:123 status
+ #> /home/nic2/arrow/cpp/src/arrow/csv/converter.cc:554 parser.VisitColumn(col_index, visit)
Review comment:
```suggestion
#> ! Invalid: In CSV column #0: CSV conversion error to time32[ms]: invalid value '2018-10-07 19:04:05.005'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1072241362
@thisisnic no, I don't think we have a licence for Pro images but I have included only free versions and that should be fine. See https://fontawesome.com/plans under **Open Source Icons** "A solid set of icons safe for use in open source projects" near the bottom of the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r829212895
##########
File path: docs/source/developers/guide/step_by_step/finding_issues.rst
##########
@@ -64,57 +67,88 @@ you will see:
How to create a JIRA issue
==========================
-After creating an account you can click **Create an issue** and select **Apache Arrow project**
-and **Type** of the issue (Bug, Feature, …).
+After creating an account you can click **Create an issue** and select
+**Apache Arrow project** and **Type** of the issue (Bug, Feature, …).
-.. figure:: jira_create_issue.jpeg
+.. figure:: /developers/images/jira_create_issue.jpeg
:scale: 70 %
:alt: creating JIRA issue
The window to create a JIRA issue.
-If you are already in JIRA dashboard click the red ``create`` button in the top to do the same.
+If you are already in JIRA dashboard click the red ``create`` button in
+the top to do the same.
-You are ready to create the issue! Add a title and a description following the
-:ref:`tips for using JIRA <jira-tips>` and you are ready to go!
+You are ready to create the issue! Add a title and a description following
+the :ref:`tips for using JIRA <jira-tips>` and you are ready to go!
.. seealso::
:ref:`Tips for using JIRA <jira-tips>`
You don’t need any special permissions on JIRA to be able to create issues.
-Once you are more involved in the project and want to do more on JIRA, for example assigning
-yourself an issue, you will need **“Contributor” permissions**. To get this role, ask on the
-:ref:`mailing_list` or in the comment of the JIRA issue you created.
+Once you are more involved in the project and want to do more on JIRA, for
+example assigning yourself an issue, you will need **“Contributor” permissions**.
+To get this role, ask on the :ref:`mailing_list` or in the comment of the JIRA
+issue you created.
-When the ticket is created you can start a discussion about it in the JIRA comments section.
+When the ticket is created you can start a discussion about it in the
+JIRA comments section.
How we use JIRA to find an issue
================================
-To make it easier for you to find issues that are well-suited for new contributors, we have added labels
-like “good-first-issue” or “beginner” to some JIRA tickets.
+To make it easier for you to find issues that are well-suited for new
+contributors, we have added labels like “good-first-issue” or “beginner”
+to some JIRA tickets.
.. seealso::
- Search for good first/second issues with labels like in the `link here
- <https://issues.apache.org/jira/issues/?filter=-4&jql=project%20%3D%20ARROW%20AND%20status%20%3D%20Open%20AND%20labels%20in%20(Beginner%2C%20beginner%2C%20beginners%2C%20beginnner%2C%20beginner-friendly%2C%20good-first-issue%2C%20good-second-issue%2C%20GoodForNewContributors%2C%20newbie%2C%20easyfix%2C%20documentation)%20order%20by%20created%20DESC>`_
+ Search for good first/second issues with labels like in the `link here
+ <https://issues.apache.org/jira/issues/?filter=-4&jql=project%20%3D%20ARROW%20AND%20status%20%3D%20Open%20AND%20labels%20in%20(Beginner%2C%20beginner%2C%20beginners%2C%20beginnner%2C%20beginner-friendly%2C%20good-first-issue%2C%20good-second-issue%2C%20GoodForNewContributors%2C%20newbie%2C%20easyfix%2C%20documentation)%20order%20by%20created%20DESC>`_
-The issues labeled as good first issues should take no more than two days or a weekend to
-fix them. Once you dig into the code you may find that the issue is not easy at all - this can
-happen as the problem could be harder than the person who triaged the ticket expected it to be.
-Don't hesitate to write that in the comments.
+The issues labeled as good first issues should take no more than two days or
+a weekend to fix them. Once you dig into the code you may find that the issue
+is not easy at all - this can happen as the problem could be harder than the
+person who triaged the ticket expected it to be. Don't hesitate to write that
+in the comments.
-.. figure:: jira_good_first_issue.jpeg
+.. figure:: /developers/images/jira_good_first_issue.jpeg
:scale: 45 %
:alt: finding good first JIRA issue
Example of the list of good first issues.
.. note::
- When you find a JIRA issue you would like to work on, please mention your interest in the comment
- section of that issue; that way we will know you are working on it.
+
+ When you find a JIRA issue you would like to work on, please mention your
+ interest in the comment section of that issue; that way we will know you
+ are working on it.
Also, do not hesitate to ask questions in the comment section of the issue.
You can get some pointers about where to start and similar issues already solved.
-**Do not forget to create a new branch once you have created or chosen an issue you will be
-working on!** Follow the instructions in the :ref:`pr_lifecycle` section or follow the next section: :ref:`arrow-codebase`.
+**What if an issue is already asigned?**
+Anything that’s not in the “In Progress” state is fair game, even if it is
+“Assigned” to someone, particularly if it has not been recently updated.
+When in doubt, comment on the issue asking if they mind if you try to put
+together a pull request; interpret no response to mean that you’re free to
+proceed.
+
+**Aske questions**
Review comment:
```suggestion
**Ask questions**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12483: ARROW-15349: [Doc][Guide] Existing Contributors page - update
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#discussion_r832981286
##########
File path: docs/source/conf.py
##########
@@ -277,7 +278,8 @@
html_static_path = ['_static']
# Custom fixes to the RTD theme
-html_css_files = ['theme_overrides.css']
+html_css_files = ['theme_overrides.css',
+ 'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css']
Review comment:
Ah, I see. I think it is fine to keep them.
In this dropdown, I suppose you cannot easily use a downloaded image as you did for the others?
Now, the theme itself should normally also already include fontawesome. So I would still think that it would even work as is without the above line. For example, if you look at [view-source:https://alenkaf.github.io/arrow-dev-docs-preview/html/developers/contributing.html](view-source:https://alenkaf.github.io/arrow-dev-docs-preview/html/developers/contributing.html), there is already some other `/vendor/fontawesome/..` css included as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org