You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/22 15:57:07 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #8242: ARROW-10065: [Rust] Simplify code (+400, -1k)
jorgecarleitao opened a new pull request #8242:
URL: https://github.com/apache/arrow/pull/8242
This is a major internal simplification of Rust's code base, with no change of functionality apart of the no longer needed `StringArrayOps` that this PR removes.
The main idea behind this PR is that when we have array types that implement `i32` and `i64` (large), we can declare them as a generic struct of the form
```
pub struct GenericXArray<OffsetSize>
```
as they have a uniform representation under the trait. Specifically:
* `[Large]BinaryArray`'s represents `[u8]`
* `[Large]ListArray`'s represents `[ArrayRef]`
* `[Large]StringArray`'s represents `[&str]`
This PR does this for
```
pub struct GenericBinaryArray<OffsetSize>
pub struct GenericStringArray<OffsetSize>
pub struct GenericListArray<OffsetSize>
```
where `OffsetSize` is either `i64` or `i32`.
This leads to a massive removal of code. Since all of this is statically typed, the actual work is done by the compiler and we just have less code to maintain.
There is more code that continues to be duplicated on `equal.rs`, but I decided to leave that to a separate PR.
FYI @nevi-me @paddyhoran @andygrove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8242:
URL: https://github.com/apache/arrow/pull/8242#issuecomment-696821165
https://issues.apache.org/jira/browse/ARROW-10065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8242:
URL: https://github.com/apache/arrow/pull/8242#issuecomment-697101767
This looks good to me conceptually at least. I wasn't too involved in this part of the codebase so I think it would be best to see if @nevi-me can review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #8242:
URL: https://github.com/apache/arrow/pull/8242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8242:
URL: https://github.com/apache/arrow/pull/8242#issuecomment-697101767
This looks good to me conceptually at least. I wasn't too involved in this part of the codebase so I think it would be best to see if @nevi-me can review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8242:
URL: https://github.com/apache/arrow/pull/8242#issuecomment-696821165
https://issues.apache.org/jira/browse/ARROW-10065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #8242:
URL: https://github.com/apache/arrow/pull/8242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org