You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2025/12/11 09:31:56 UTC

[PR] upgrade to latest scala (2.13.18, 2.12.21, 3.3.7) (#560) [pekko-grpc]

pjfanning opened a new pull request, #565:
URL: https://github.com/apache/pekko-grpc/pull/565

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade to latest scala (2.13.18, 2.12.21, 3.3.7) (#560) [pekko-grpc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #565:
URL: https://github.com/apache/pekko-grpc/pull/565#discussion_r2609995346


##########
sbt-plugin/src/sbt-test/gen-java/01-gen-basic-java/build.sbt:
##########
@@ -7,9 +7,7 @@
  * This file is part of the Apache Pekko project, which was derived from Akka.
  */
 
-// Can be removed when we move to 2.12.14
-// https://github.com/akka/akka-grpc/pull/1279
-scalaVersion := "2.12.20"
+scalaVersion := "2.12.21"

Review Comment:
   I tried to remove them on main branch and nothing worked



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade to latest scala (2.13.18, 2.12.21, 3.3.7) (#560) [pekko-grpc]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #565:
URL: https://github.com/apache/pekko-grpc/pull/565#issuecomment-3641239166

   moved link validator to schedule in #564 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade to latest scala (2.13.18, 2.12.21, 3.3.7) (#560) [pekko-grpc]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #565:
URL: https://github.com/apache/pekko-grpc/pull/565#discussion_r2609883858


##########
sbt-plugin/src/sbt-test/gen-java/01-gen-basic-java/build.sbt:
##########
@@ -7,9 +7,7 @@
  * This file is part of the Apache Pekko project, which was derived from Akka.
  */
 
-// Can be removed when we move to 2.12.14
-// https://github.com/akka/akka-grpc/pull/1279
-scalaVersion := "2.12.20"
+scalaVersion := "2.12.21"

Review Comment:
   are we sure we still need the explicit scala version here? the comment/issue seems to suggest it was only added because of a specific problem with 2.12.13



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] upgrade to latest scala (2.13.18, 2.12.21, 3.3.7) (#560) [pekko-grpc]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #565:
URL: https://github.com/apache/pekko-grpc/pull/565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org