You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/05/12 16:24:00 UTC

[jira] [Commented] (IMPALA-11286) Implement impala write 'values_counts' to Iceberg meta

    [ https://issues.apache.org/jira/browse/IMPALA-11286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536216#comment-17536216 ] 

ASF subversion and git services commented on IMPALA-11286:
----------------------------------------------------------

Commit e711461a5ce500b803f0b0ac49ae8d09c6daab4f in impala's branch refs/heads/master from LPL
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e711461a5 ]

IMPALA-11286: Writes value_counts to Iceberg metadata

Impala does not write 'value_counts' to Iceberg metadata, just
'null_value_counts'. Push-down NOT_NULL predicate does not work when the
data is written by the impala, so we implement impala to write
'value_counts' to Iceberg metadata.

Testing:
 - existing tests
 - tested manually on a real cluster

Change-Id: I6b7afab8be197118e573fda1a381fa08e4c8c9c0
Reviewed-on: http://gerrit.cloudera.org:8080/18513
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Implement impala write 'values_counts' to Iceberg meta
> ------------------------------------------------------
>
>                 Key: IMPALA-11286
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11286
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: LiPenglin
>            Assignee: LiPenglin
>            Priority: Major
>              Labels: impala-iceberg
>
> Impala doesn't write 'value_counts', only 'null_value_counts'.
> [https://github.com/apache/impala/blob/1f20b7aa51b5c93dea03515423def2d800f43554/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java#L316]
> 'values_counts' is very helpful for pushing down NOT_NULL predicate, so we should implement impala write 'values_counts' to Iceberg Meta.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org