You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/24 13:34:35 UTC
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3834: Fix: The metrics view API response is not super-set of resources
response keys
DaanHoogland commented on a change in pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#discussion_r370635191
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/VolumeResponse.java
##########
@@ -293,7 +293,7 @@ public String getObjectId() {
return this.getId();
}
- public Boolean isDestroyed() {
+ public Boolean getDestroyed() {
Review comment:
boolean getter should adhere to is<attr>() pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services