You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/13 13:37:31 UTC

[GitHub] [tinkerpop] danielcweber opened a new pull request, #1698: Complete ResponseStatusCodeEnum in .NET

danielcweber opened a new pull request, #1698:
URL: https://github.com/apache/tinkerpop/pull/1698

   Add missing response status codes to the enum in .NET. Currently, it is not possible to use the new fail()-operator since it'll 
   return a new status code (595) which makes the `IndicatesError` method throw.
   
   @FlorianHockmann Maybe this justifies an out-of-band release of a patched Gremlin.NET ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] spmallette merged pull request #1698: Complete ResponseStatusCodeEnum in .NET (3.6-dev)

Posted by GitBox <gi...@apache.org>.
spmallette merged PR #1698:
URL: https://github.com/apache/tinkerpop/pull/1698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] danielcweber commented on a diff in pull request #1698: Complete ResponseStatusCodeEnum in .NET

Posted by GitBox <gi...@apache.org>.
danielcweber commented on code in PR #1698:
URL: https://github.com/apache/tinkerpop/pull/1698#discussion_r898874673


##########
gremlin-dotnet/src/Gremlin.Net/Driver/Messages/ResponseStatusCode.cs:
##########
@@ -76,6 +92,22 @@ public enum ResponseStatusCode
         /// </summary>
         ServerError = 500,
 
+        /// <summary>
+        ///     A server error that indicates that the client should retry the request. A graph will typically return this error

Review Comment:
   Resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] spmallette commented on pull request #1698: Complete ResponseStatusCodeEnum in .NET

Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1698:
URL: https://github.com/apache/tinkerpop/pull/1698#issuecomment-1156955093

   weird that these were missing. i guess we dont have tests for those. VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] danielcweber commented on pull request #1698: Complete ResponseStatusCodeEnum in .NET (3.6-dev)

Posted by GitBox <gi...@apache.org>.
danielcweber commented on PR #1698:
URL: https://github.com/apache/tinkerpop/pull/1698#issuecomment-1157427639

   PR for the 3.5-dev-branch to be found in #1710.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] FlorianHockmann commented on a diff in pull request #1698: Complete ResponseStatusCodeEnum in .NET

Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on code in PR #1698:
URL: https://github.com/apache/tinkerpop/pull/1698#discussion_r898855692


##########
gremlin-dotnet/src/Gremlin.Net/Driver/Messages/ResponseStatusCode.cs:
##########
@@ -76,6 +92,22 @@ public enum ResponseStatusCode
         /// </summary>
         ServerError = 500,
 
+        /// <summary>
+        ///     A server error that indicates that the client should retry the request. A graph will typically return this error

Review Comment:
   Looks like a copy-paste error. The [Java docs here](https://github.com/apache/tinkerpop/blob/8e8d19d231fc3cd25659f46adabe95ce47973598/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/message/ResponseStatusCode.java#L120) are actually:
   
   ```java
   /**
    * A server error that is produced when the {@link GraphTraversal#fail()} step is triggered. The returned exception
    * will include information consistent with the {@link Failure} interface.
    *
    * @since 3.6.0
    */
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] danielcweber commented on pull request #1698: Complete ResponseStatusCodeEnum in .NET (3.6-dev)

Posted by GitBox <gi...@apache.org>.
danielcweber commented on PR #1698:
URL: https://github.com/apache/tinkerpop/pull/1698#issuecomment-1157428752

   @FlorianHockmann
   
   >If the fail() step is important for you...
   
   It'll become important to us once AWS Neptune moves to 3.6. Thanks for considering an rc-release!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org