You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by ramiromagalhaes <gi...@git.apache.org> on 2015/09/03 23:21:05 UTC
[GitHub] jena pull request: Making Model attributes private and final in ma...
GitHub user ramiromagalhaes opened a pull request:
https://github.com/apache/jena/pull/92
Making Model attributes private and final in many vocabulary classes.
As requested in https://issues.apache.org/jira/browse/JENA-1019, here is my change proposal.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramiromagalhaes/jena master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit d0f9daa4b9dcbf7678917cf404debdb8ba1c6485
Author: Ramiro Pereira de Magalhães <ra...@gmail.com>
Date: 2015-09-03T21:13:03Z
Making Model attributes private and final in many vocabulary classes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1019 - Making Model attributes private and...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/92#issuecomment-138095533
Changes applied. Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1019 - Making Model attributes private and...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/92#issuecomment-138002455
The changes to what look like hand-written vocabularies look good.
Some of these files appear to have been autogenerated by schemagen (e.g the ones where the model is `static private m_model` already).
1. As they are private, the compiler will treat them as "effectively final" anyway.
1. The files may get overwritten.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1019 - Making Model attributes private and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---