You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/30 02:29:39 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests
ableegoldman opened a new pull request #11146:
URL: https://github.com/apache/kafka/pull/11146
Addresses the handful of remaining feedback from [Pt. 2](https://github.com/apache/kafka/pull/10683), plus adds two new tests: one verifying a multi-topology application with a FKJ and its internal topics, another to make sure IQ works with named topologies (though note that there is a bit more work left for IQ to be fully supported, will be tackled after [Pt. 3](https://github.com/apache/kafka/pull/10788)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11146:
URL: https://github.com/apache/kafka/pull/11146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11146:
URL: https://github.com/apache/kafka/pull/11146#issuecomment-890059151
Merged to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #11146:
URL: https://github.com/apache/kafka/pull/11146#discussion_r680126350
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -118,12 +118,18 @@ public boolean hasNamedTopologies() {
return !builders.containsKey(UNNAMED_TOPOLOGY);
}
+ /**
+ * @return true iff any of the topologies have a global topology
Review comment:
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11146:
URL: https://github.com/apache/kafka/pull/11146#issuecomment-889585580
also cc @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on a change in pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on a change in pull request #11146:
URL: https://github.com/apache/kafka/pull/11146#discussion_r680010884
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -118,12 +118,18 @@ public boolean hasNamedTopologies() {
return !builders.containsKey(UNNAMED_TOPOLOGY);
}
+ /**
+ * @return true iff any of the topologies have a global topology
Review comment:
do you mean if and only if by `iff`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org