You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bifromq.apache.org by "popduke (via GitHub)" <gi...@apache.org> on 2025/07/30 03:22:46 UTC

[PR] Various small improvements and code cleanup [bifromq]

popduke opened a new pull request, #159:
URL: https://github.com/apache/bifromq/pull/159

   1. Improved HLC impl and documentation
   2. Improved the ReplicaCntBalancer to better handle an edge case
   3. Improved session memory usage estimation
   4. Added contextual tags to heuristic compactor's metrics in basekv-local-engine
   5. Enabled pin data for kv iterator to improve memory consumption in some cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bifromq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Various small improvements and code cleanup [bifromq]

Posted by "Gujiawei-Edinburgh (via GitHub)" <gi...@apache.org>.
Gujiawei-Edinburgh merged PR #159:
URL: https://github.com/apache/bifromq/pull/159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bifromq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Various small improvements and code cleanup [bifromq]

Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #159:
URL: https://github.com/apache/bifromq/pull/159#issuecomment-3134799700

   ## Pull Request Test Coverage Report for [Build 16612654614](https://coveralls.io/builds/74856930)
   
   
   ### Details
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **278** unchanged lines in **10** files lost coverage.
   * Overall coverage increased (+**0.06%**) to **63.127%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [org/apache/bifromq/mqtt/handler/v3/MQTT3PersistentSessionHandler.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fmqtt%2Fhandler%2Fv3%2FMQTT3PersistentSessionHandler.java#L82) | 1 | 88.89% |
   | [org/apache/bifromq/basekv/store/stats/StatsCollector.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fbasekv%2Fstore%2Fstats%2FStatsCollector.java#L56) | 2 | 78.95% |
   | [org/apache/bifromq/dist/trie/TopicFilterIterator.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fdist%2Ftrie%2FTopicFilterIterator.java#L76) | 5 | 68.7% |
   | [org/apache/bifromq/basekv/localengine/rocksdb/RocksDBKVEngineIterator.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fbasekv%2Flocalengine%2Frocksdb%2FRocksDBKVEngineIterator.java#L54) | 7 | 78.57% |
   | [org/apache/bifromq/basecluster/memberlist/AutoDropper.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fbasecluster%2Fmemberlist%2FAutoDropper.java#L145) | 8 | 78.65% |
   | [org/apache/bifromq/basekv/balance/impl/ReplicaCntBalancer.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fbasekv%2Fbalance%2Fimpl%2FReplicaCntBalancer.java#L92) | 13 | 81.02% |
   | [org/apache/bifromq/basehlc/HLC.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fbasehlc%2FHLC.java#L39) | 15 | 61.73% |
   | [org/apache/bifromq/mqtt/handler/MQTTTransientSessionHandler.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fmqtt%2Fhandler%2FMQTTTransientSessionHandler.java#L140) | 18 | 82.83% |
   | [org/apache/bifromq/mqtt/handler/MQTTPersistentSessionHandler.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fmqtt%2Fhandler%2FMQTTPersistentSessionHandler.java#L129) | 41 | 74.51% |
   | [org/apache/bifromq/mqtt/handler/MQTTSessionHandler.java](https://coveralls.io/builds/74856930/source?filename=org%2Fapache%2Fbifromq%2Fmqtt%2Fhandler%2FMQTTSessionHandler.java#L252) | 168 | 74.47% |
   <!-- | **Total:** | **278** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/74856930/badge)](https://coveralls.io/builds/74856930) |
   | :-- | --: |
   | Change from base [Build 16591047944](https://coveralls.io/builds/74839666): |  0.06% |
   | Covered Lines: | 23606 |
   | Relevant Lines: | 36106 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bifromq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org